fix(keyring-eth-ledger-bridge): device id should be cleared up when forgetting a device #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akaryatrh
added
the
team-hardware-wallets
ccharly
reviewed
Nov 6, 2024
ccharly
approved these changes
Nov 6, 2024
ccharly
changed the title
mikesposito
reviewed
Nov 6, 2024
mikesposito
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we call forgetDevice function from ledger keyring, it doesn't clear up the stored
deviceId. This could be a blocker when checking for existing storeddeviceIdclient side.Then, this will unblock a fix for multiple devices handling as an issue has been found during QA testing related to
deviceId.