Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move add contact button in fullscreen/expanded view lower. #9883

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

tmashuang
Copy link
Contributor

@tmashuang tmashuang commented Nov 13, 2020

Fixes #9868

Move the add contact button that is overlapping (x)/close setting icon lower, on the same line as Contacts in fullscreen/expanded view. This should only move the button in the fullscreen/expanded view, and it should not change the button position in the extension/popup view, which overlaps the close(x) icon as well.

Before
After

Fixes #9868

Move the add contact button that is overlapping (x)/close setting icon lower, on the same line as Contacts in fullscreen/expanded view.
@tmashuang tmashuang requested a review from a team as a code owner November 13, 2020 20:23
@tmashuang tmashuang requested a review from Gudahtt November 13, 2020 20:23
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tmashuang tmashuang changed the title Move add contact button in fullscreen/expanded view. Move add contact button in fullscreen/expanded view lower. Nov 13, 2020
@metamaskbot
Copy link
Collaborator

Builds ready [c0c38b4]
Page Load Metrics (433 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint3196542110
domContentLoaded27770543211254
load28170643311254
domInteractive27770443111254

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tmashuang tmashuang merged commit 302b7dd into develop Nov 16, 2020
@tmashuang tmashuang deleted the move-add-contact-button-lower branch November 16, 2020 20:07
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

+ button overlaps/hides x button in Settings -> Contacts
3 participants