Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+ button overlaps/hides x button in Settings -> Contacts #9868

Closed
d10r opened this issue Nov 13, 2020 · 0 comments · Fixed by #9883
Closed

+ button overlaps/hides x button in Settings -> Contacts #9868

d10r opened this issue Nov 13, 2020 · 0 comments · Fixed by #9883
Labels
Sev2-normal Normal severity; minor loss of service or inconvenience. type-bug

Comments

@d10r
Copy link

d10r commented Nov 13, 2020

image

Seen in Brave with Metamask 8.1.3.
The blue + button on the top right overlaps / hides the x (close) button.

The screenshot was done with Metamask in expanded mode, but it's the same (for me) in popup mode.
tmashuang added a commit that referenced this issue Nov 13, 2020
@tmashuang
Move add contact button in fullscreen/expanded view.
7bf4e52 
Fixes #9868

Move the add contact button that is overlapping (x)/close setting icon lower, on the same line as Contacts in fullscreen/expanded view.
@tmashuang tmashuang mentioned this issue Nov 13, 2020
Merged
@Gudahtt Gudahtt added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. labels Nov 13, 2020
tmashuang added a commit that referenced this issue Nov 16, 2020
@tmashuang
Move add contact button in fullscreen/expanded view lower. (#9883)
302b7dd 
* Move add contact button in fullscreen/expanded view.

Fixes #9868

Move the add contact button that is overlapping (x)/close setting icon lower, on the same line as Contacts in fullscreen/expanded view.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Sev2-normal Normal severity; minor loss of service or inconvenience. type-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move add contact button in fullscreen/expanded view lower. MetaMask/metamask-extension
2 participants
@Gudahtt @d10r