Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ListItem styles #9002

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Fix ListItem styles #9002

merged 1 commit into from
Jul 15, 2020

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jul 15, 2020

The styles for the ListItem component were recently broken in #8989 because of a change made by stylelint. It incorrectly removed the fr unit because of the length-zero-no-unit rule. This was a bug that has since been fixed in stylelint; it should have left the fr unit in this case.

@Gudahtt
Copy link
Member Author

Gudahtt commented Jul 15, 2020

This depends upon #9001

@metamaskbot
Copy link
Collaborator

Builds ready [32377e3]
Page Load Metrics (606 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31105442211
domContentLoaded3716806057837
load3736816067837
domInteractive3716796057837

Base automatically changed from update-stylelint to develop July 15, 2020 19:03
@Gudahtt
Fix ListItem styles
3d5f83e 
The styles for the `ListItem` component were recently broken in #8989
because of a change made by `stylelint`. It incorrectly removed the
`fr` unit because of the `length-zero-no-unit` rule. This was a bug
that has since been fixed in `stylelint`; it should have left the `fr`
unit in this case.
@Gudahtt Gudahtt force-pushed the fix-list-item-styles branch from 32377e3 to 3d5f83e Compare July 15, 2020 19:03
@Gudahtt Gudahtt marked this pull request as ready for review July 15, 2020 19:07
@Gudahtt Gudahtt requested a review from a team as a code owner July 15, 2020 19:07
whymarrh
whymarrh approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@metamaskbot
Copy link
Collaborator

Builds ready [3d5f83e]
Page Load Metrics (640 ± 31 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31110532713
domContentLoaded3977406396531
load3997426406531
domInteractive3977396386531

@Gudahtt Gudahtt merged commit acaa648 into develop Jul 15, 2020
@Gudahtt Gudahtt deleted the fix-list-item-styles branch July 15, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gudahtt @metamaskbot @whymarrh