Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stylelint from v9.10.1 to v13.6.1 #9001

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Update stylelint from v9.10.1 to v13.6.1 #9001

merged 1 commit into from
Jul 15, 2020

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jul 15, 2020 •
edited
Loading

The changes made between v9.10.1 and v13.6.1 don't appear to be relevant to us, aside from bug fixes that we'd benefit from.

gulp-stylelint also needed to be updated, as it's in-step with stylelint. It went from v7 to v13.0.0. The changes aren't notable here for us either.

Gudahtt
Gudahtt commented Jul 15, 2020
View reviewed changes
yarn.lock Show resolved Hide resolved
brad-decker
brad-decker previously approved these changes Jul 15, 2020
View reviewed changes
@Gudahtt Gudahtt force-pushed the update-stylelint branch from f40faa5 to c182a7c Compare July 15, 2020 17:55
@Gudahtt
Update stylelint from v9.10.1 to v13.6.1
38b1c19 
The changes made between v9.10.1 and v13.6.1 don't appear to be
relevant to us, aside from bug fixes that we'd benefit from.

`gulp-stylelint` also needed to be updated, as it's in-step with
`stylelint`. It went from v7 to v13.0.0. The changes aren't notable
here for us either.
@Gudahtt Gudahtt force-pushed the update-stylelint branch from c182a7c to 38b1c19 Compare July 15, 2020 18:26
@Gudahtt Gudahtt mentioned this pull request Jul 15, 2020
Merged
@Gudahtt Gudahtt marked this pull request as ready for review July 15, 2020 18:57
@Gudahtt Gudahtt requested a review from a team as a code owner July 15, 2020 18:57
whymarrh
whymarrh approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [38b1c19]
Page Load Metrics (589 ± 28 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint2910140189
domContentLoaded3396255885928
load3416265895928
domInteractive3396245885928

@Gudahtt Gudahtt merged commit 49c46c9 into develop Jul 15, 2020
@Gudahtt Gudahtt deleted the update-stylelint branch July 15, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@brad-decker brad-decker brad-decker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gudahtt @metamaskbot @whymarrh @brad-decker