Use async/await for "message manager" action creators
#8434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
use-async-await-in-action-creators-that-update-metamask-state
branch
from
3b3a505 to
2f995de
Compare
Builds ready [2f995de]
|
|
I had done this originally in preparation for allowing |
These action creators for the "message manager" controller interactions have been updated to use `async/await`. There should be almost no changes in behavior. The only things removed were a few debug log statements, and a single `console.log`.
Gudahtt
force-pushed
the
use-async-await-in-action-creators-that-update-metamask-state
branch
from
2f995de to
12a4c3d
Compare
Gudahtt
changed the title
async/await for action creators that call updateMetamaskStateasync/await for "message manager" action creators
Builds ready [12a4c3d]
|
whymarrh
approved these changes
Apr 28, 2020
Gudahtt
deleted the
use-async-await-in-action-creators-that-update-metamask-state
branch
Gudahtt
added a commit
that referenced
this pull request
Jul 15, 2020
The loading indication had remained after successfully signing with `personal_sign`. This mistake was introduced accidentally in #8434. This is noticeable if you confirm the signature in the popup UI or fullscreen UI, as they remain open after signing. The notification UI closes after signing without waiting for this loading indicator to be removed.
Gudahtt
added a commit
that referenced
this pull request
Jul 16, 2020
The loading indication had remained after successfully signing with `personal_sign`. This mistake was introduced accidentally in #8434. This is noticeable if you confirm the signature in the popup UI or fullscreen UI, as they remain open after signing. The notification UI closes after signing without waiting for this loading indicator to be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These action creators for the "message manager" controller interactions have been updated to use
async/await. There should be almost no changes in behavior. The only things removed were a few debug log statements, and a singleconsole.log.