Fix batch transaction UX #7473
Merged
Fix batch transaction UX #7473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
requested review from
danjm,
frankiebee,
Gudahtt and
whymarrh
as code owners
Gudahtt
reviewed
Nov 20, 2019
Merged
whymarrh
suggested changes
Nov 20, 2019
rekmarks
force-pushed
the
update-rpc-engine
branch
from
8d25d28 to
348f072
Compare
Default to showing the earliest created transaction when routing to confirm screens
rekmarks
force-pushed
the
update-rpc-engine
branch
from
348f072 to
16a085f
Compare
rekmarks
added
area-UI
rekmarks
force-pushed
the
update-rpc-engine
branch
2 times, most recently
from
d9b8d53 to
b599858
Compare
rekmarks
force-pushed
the
update-rpc-engine
branch
from
b599858 to
5ed8494
Compare
rekmarks
commented
Jan 9, 2020
Comment on lines
-856
to
+858
| await driver.wait(until.elementTextMatches(balance, /^87.*\s*ETH.*$/), 10000) | ||
| await driver.wait(until.elementTextMatches(balance, /^90.*\s*ETH.*$/), 10000) | ||
| const tokenAmount = await balance.getText() | ||
| assert.ok(/^87.*\s*ETH.*$/.test(tokenAmount)) | ||
| assert.ok(/^90.*\s*ETH.*$/.test(tokenAmount)) |
There was a problem hiding this comment.
These changes are due to a send of 3 ETH now being rejected instead of approved due to the updated UI transaction order. An equivalent solution would be to ensure that transaction is approved, this was just easier.
Builds ready [5ed8494]
|
whymarrh
approved these changes
Jan 10, 2020
| @@ -26,7 +26,7 @@ const typeHash = { | |||
|
|
|||
| const Button = ({ type, submit, large, children, className, ...buttonProps }) => ( | |||
| <button | |||
| type={submit && 'submit'} | |||
| type={submit ? 'submit' : undefined} | |||
Gudahtt
pushed a commit
that referenced
this pull request
Jan 10, 2020
* order transactions from oldest to newest in UI * update json-rpc-engine, eth-json-rpc-middleware * update e2e and integration tests
Gudahtt
added a commit
that referenced
this pull request
Jan 10, 2020
These tests were updated in #7473 to navigate in a different order, because the transaction order changed. Unfortunately this meant that a second contract deployment was being confirmed, where it was previously being rejected. This updates the test to ensure the same transaction is rejected and confirmed as prior to the change in #7473
Gudahtt
added a commit
that referenced
this pull request
Jan 10, 2020
These tests were updated in #7473 to navigate in a different order, because the transaction order changed. Unfortunately this meant that a second contract deployment was being confirmed, where it was previously being rejected. This updates the test to ensure the same transaction is rejected and confirmed as prior to the change in #7473
Gudahtt
added a commit
that referenced
this pull request
Jan 10, 2020
These tests were updated in #7473 to navigate in a different order, because the transaction order changed. Unfortunately this meant that a second contract deployment was being confirmed, where it was previously being rejected. This updates the test to ensure the same transaction is rejected and confirmed as prior to the change in #7473
Gudahtt
added a commit
that referenced
this pull request
Jan 13, 2020
These tests were updated in #7473 to navigate in a different order, because the transaction order changed. Unfortunately this meant that a second contract deployment was being confirmed, where it was previously being rejected. This updates the test to ensure the same transaction is rejected and confirmed as prior to the change in #7473
yqrashawn
pushed a commit
to yqrashawn/conflux-portal
that referenced
this pull request
Jan 14, 2020
* order transactions from oldest to newest in UI * update json-rpc-engine, eth-json-rpc-middleware * update e2e and integration tests
yqrashawn
pushed a commit
to yqrashawn/conflux-portal
that referenced
this pull request
Jan 15, 2020
These tests were updated in MetaMask#7473 to navigate in a different order, because the transaction order changed. Unfortunately this meant that a second contract deployment was being confirmed, where it was previously being rejected. This updates the test to ensure the same transaction is rejected and confirmed as prior to the change in MetaMask#7473
yqrashawn
pushed a commit
to Conflux-Chain/conflux-portal
that referenced
this pull request
Jan 15, 2020
* order transactions from oldest to newest in UI * update json-rpc-engine, eth-json-rpc-middleware * update e2e and integration tests
yqrashawn
pushed a commit
to Conflux-Chain/conflux-portal
that referenced
this pull request
Jan 15, 2020
These tests were updated in MetaMask#7473 to navigate in a different order, because the transaction order changed. Unfortunately this meant that a second contract deployment was being confirmed, where it was previously being rejected. This updates the test to ensure the same transaction is rejected and confirmed as prior to the change in MetaMask#7473
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending
Fixes batch transaction UX by addressing long-standing errors in batch transaction handling in the UI, and modifying
json-rpc-engine's ordered batch request handling. Transactions are now ordered from oldest to newest in the background and in the UI. Users can still freely navigate back and forth.Fixes #5852