Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint import plugin to help detect unresolved paths #7416

Merged
merged 2 commits into from
Nov 14, 2019

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 13, 2019

Most of the rules in the import plugin are only useful for projects using purely ES6 imports. The no-unresolved rule works with mixed CommonJS and ES6 though, so we at least benefit from that in the
meantime.

Most of the rules in the import plugin are only useful for projects
using purely ES6 imports. The `no-unresolved` rule works with mixed
CommonJS and ES6 though, so we at least benefit from that in the
meantime.
Certain lines only work after a build stage has been completed, so
these failure can be ignored by the no-unresolved rule.
@Gudahtt Gudahtt force-pushed the add-eslint-import-plugin branch from eddac08 to 9ca22d8 Compare November 14, 2019 13:19
@metamaskbot
Copy link
Collaborator

Builds ready [9ca22d8]

Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a solid QoL improvement!

@Gudahtt Gudahtt merged commit a34f1ea into develop Nov 14, 2019
@Gudahtt Gudahtt deleted the add-eslint-import-plugin branch November 14, 2019 18:28
@Gudahtt
Copy link
Member Author

Gudahtt commented Nov 14, 2019

Gah, merged instead of squash. Oops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants