Merge pull request #7416 from MetaMask/add-eslint-import-plugin

Add eslint import plugin to help detect unresolved paths

.eslintrc

@@ -30,7 +30,8 @@
     "mocha",
     "chai",
     "react",
-    "json"
+    "json",
+    "import"
   ],
 
   "globals": {
@@ -43,6 +44,7 @@
   },
 
   "rules": {
+    "import/no-unresolved": ["error", { "commonjs": true }],
     "no-restricted-globals": ["error", "event"],
     "accessor-pairs": 2,
     "arrow-spacing": [2, { "before": true, "after": true }],

development/metamaskbot-build-announce.js

@@ -1,6 +1,6 @@
 #!/usr/bin/env node
 const request = require('request-promise')
-const VERSION = require('../dist/chrome/manifest.json').version
+const VERSION = require('../dist/chrome/manifest.json').version // eslint-disable-line import/no-unresolved
 
 start().catch(console.error)
 

development/mock-dev.js

@@ -15,14 +15,16 @@ const h = require('react-hyperscript')
 const Root = require('../ui/app/pages')
 const configureStore = require('../ui/app/store/store')
 const actions = require('../ui/app/store/actions')
-const states = require('./states')
 const backGroundConnectionModifiers = require('./backGroundConnectionModifiers')
 const Selector = require('./selector')
 const MetamaskController = require('../app/scripts/metamask-controller')
 const firstTimeState = require('../app/scripts/first-time-state')
 const ExtensionPlatform = require('../app/scripts/platforms/extension')
 const noop = function () {}
 
+// the states file is generated before this file is run, but after `lint` is run
+const states = require('./states') /* eslint-disable-line import/no-unresolved */
+
 const log = require('loglevel')
 window.log = log
 log.setLevel('debug')

development/sentry-publish.js

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 const pify = require('pify')
 const exec = pify(require('child_process').exec, { multiArgs: true })
-const VERSION = require('../dist/chrome/manifest.json').version
+const VERSION = require('../dist/chrome/manifest.json').version // eslint-disable-line import/no-unresolved
 
 start().catch(console.error)
 

package.json

@@ -189,6 +189,7 @@
     "@babel/preset-react": "^7.0.0",
     "@babel/register": "^7.5.5",
     "@sentry/cli": "^1.30.3",
+    "@storybook/addon-actions": "^5.2.6",
     "@storybook/addon-info": "^5.1.1",
     "@storybook/addon-knobs": "^3.4.2",
     "@storybook/react": "^5.1.1",
@@ -211,6 +212,7 @@
     "enzyme-adapter-react-15": "^1.0.6",
     "eslint": "^6.0.1",
     "eslint-plugin-chai": "0.0.1",
+    "eslint-plugin-import": "^2.18.2",
     "eslint-plugin-json": "^1.2.0",
     "eslint-plugin-mocha": "^5.0.0",
     "eslint-plugin-react": "^7.4.0",