Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip drizzle tests until issue with ci is determined #5982

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

tmashuang
Copy link
Contributor

@tmashuang tmashuang commented Jan 1, 2019

Hold off on drizzle test until issue with ci

  • gyp WARN EACCES user "root" does not have permission to access the dev dir "/root/.node-gyp/8.11.3"
    Can be resolved with adding sudo npm install -g truffle --unsafe-perm line 9 in run-drizzle.sh

  • Next issue is with
    Error: Errors found in browser console:
    http://127.0.0.1:3000/static/js/bundle.js 99432:20 "Contract ComplexStorage not found on network ID: 1546373425748"
    http://127.0.0.1:3000/static/js/bundle.js 99432:20 "uncaught at root"
    Seems to be an issue with truffle compile && truffle migrate not running when ganache is open. Haven't confirmed if Ganache is actually open in background of ci, but extension seems to be connected to it.

@tmashuang tmashuang changed the title Skip drizzle tests unit issue with ci is determined Skip drizzle tests until issue with ci is determined Jan 1, 2019
@tmashuang
Copy link
Contributor Author

Closing in favor of #5980

@tmashuang tmashuang closed this Jan 2, 2019
@tmashuang tmashuang reopened this Jan 16, 2019
@tmashuang
Copy link
Contributor Author

tmashuang commented Jan 16, 2019

New truffle/dizzle issue with the latest update. First issue was
https://circleci.com/gh/MetaMask/metamask-extension/78004

Truffle override the top level node_module. I alleviated by creating a new directory and moving into it.
tmashuang@853d173
CI results https://circleci.com/gh/tmashuang/metamask-extension/4428

Previously, https://github.com/truffle-box/drizzle-box/blob/3f9dbcd6ed5827ddb84115982e59935e4daa64fe/truffle-config.js development network settings was configured by default.

With the latest update, the development network setting is no longer provided to us. https://github.com/truffle-box/drizzle-box/blob/a0088e9d5783a93eca93a5528356ff5c2c6a6619/truffle-config.js

Copy link
Contributor

@danfinlay danfinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should unblock our release PR.

@danfinlay danfinlay merged commit 1346330 into develop Jan 16, 2019
@danfinlay danfinlay deleted the hold-drizzle-tests branch January 16, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants