Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix drizzle tests #5980

Merged
merged 5 commits into from
Jan 2, 2019
Merged

Fix drizzle tests #5980

merged 5 commits into from
Jan 2, 2019

Conversation

brunobar79
Copy link
Contributor

@brunobar79 brunobar79 commented Dec 31, 2018 •
edited
Loading

The main change is to not install truffle globally, which requires sudo and introduces some other problems, and calling it from node_modules/.bin/truffle instead

@brunobar79 brunobar79 closed this Dec 31, 2018
@brunobar79 brunobar79 reopened this Jan 2, 2019
@brunobar79 brunobar79 changed the title Dont use sudo to install truffle (drizzle test fix) Attempt to fix drizzle tests Jan 2, 2019
@brunobar79 brunobar79 changed the title Attempt to fix drizzle tests Fix drizzle tests Jan 2, 2019
@metamaskbot
Copy link
Collaborator

Builds ready [3112d5b]: mascara, chrome, firefox, edge, opera

@metamaskbot
Copy link
Collaborator

Builds ready [c349bbd]: mascara, chrome, firefox, edge, opera

@tmashuang tmashuang mentioned this pull request Jan 2, 2019
Merged
2 tasks
@tmashuang tmashuang merged commit e43f5d3 into develop Jan 2, 2019
@tmashuang tmashuang deleted the fix-drizzle-tests branch January 2, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmashuang tmashuang tmashuang approved these changes

@whymarrh whymarrh Awaiting requested review from whymarrh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brunobar79 @metamaskbot @tmashuang