Allow zero gasPrice on testnet. #4037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 19, 2018
|
@danfinlay Please check this issue :) |
|
Fixes #3074 We'll review this soon. |
|
Please also add an entry to |
|
Added line "Allow zero gasPrice on testnet" on CHANGELOG.md |
|
We talked about this, and are willing to close this in favor of #4058. Should be an even simpler PR if you want to submit it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Metamask doesn't allow zero gasPrice.
It is natural to restrict gasPrice on mainnet, however it shouldn't be restricted to 0.1 wei on testnet.
This restriction makes development uncomfortable. (there are issues related to this: #3888, #3074)