Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve gas price suggestions in retry tx's #5782

Closed
frankiebee opened this issue Nov 19, 2018 · 5 comments
Closed

improve gas price suggestions in retry tx's #5782

frankiebee opened this issue Nov 19, 2018 · 5 comments
Assignees
Labels
area-UI Relating to the user interface. type-bug

Comments

@frankiebee
Copy link
Contributor

At this moment the gas price can be set to 0... which when retried the minimum can be set to 0 because 0 / 100 * 10 = 0 so lets not do this because txs will either fail or hang in pending.

I can do the background if you want to handle the ui @danjm

@frankiebee frankiebee added type-bug area-UI Relating to the user interface. labels Nov 19, 2018
@tmashuang
Copy link
Contributor

#4058
#4073
#4037

TLDR; private/test networks. Maybe just mainnet?

@danfinlay
Copy link
Contributor

Rather than doing a blanket ban on a price that could be valid for many networks, I'd like to learn why 0 was estimated.

The retry issue would be solved with #5779.

@frankiebee
Copy link
Contributor Author

@danfinlay 0 was not estimated for gasPrice the user chose it

@frankiebee
Copy link
Contributor Author

and then was able to continue using it through the retries. The actual recommended gas price was ignored

@frankiebee frankiebee changed the title Dont allow gasPrice to be set to 0 improve gas price suggestions in retry tx's Nov 26, 2018
@frankiebee
Copy link
Contributor Author

i've renamed this issue to better reflect the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface. type-bug
Projects
None yet
Development

No branches or pull requests

4 participants