Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix account list item for portfolio view #28598

Merged

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Nov 21, 2024

Description

Fixes account list item wit Portfolio view feature flag.

Open in GitHub Codespaces

Related issues

Fixes: #28592

Manual testing steps

Make sure you run the steps with AND without the PORTFOLIO_VIEW flag

  1. Go to settings => Security and privacy => and disable "Show balance and token price checker"
  2. Open account picker make sure you see crypto values
  3. Enable the setting again and you should see Fiat values

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri marked this pull request as ready for review November 21, 2024 09:23
@sahar-fehri sahar-fehri requested review from a team as code owners November 21, 2024 09:23
@sahar-fehri sahar-fehri added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Nov 21, 2024
@sahar-fehri sahar-fehri force-pushed the fix/fix-display-account-list-item-with-portfolio-view branch from 21e4f8d to 7019e84 Compare November 21, 2024 09:36
@metamaskbot
Copy link
Collaborator

Builds ready [7019e84]
Page Load Metrics (1899 ± 98 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16052319189919392
domContentLoaded15962223186317684
load16052334189920498
domInteractive27107502311
backgroundConnect10194404321
firstReactRender643181395527
getState4124162713
initialActions01000
loadScripts11571687137715072
setupStore584192512
uiStartup177730012186319153
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@salimtb
Copy link
Contributor

salimtb commented Nov 21, 2024

QA done , works as expected , LGTM

@Unik0rnMaggie
Copy link
Contributor

Confirming the fix works for both account selector and send flow.

Screenshot 2024-11-21 at 12 39 20
Screenshot 2024-11-21 at 12 39 56
Screenshot 2024-11-21 at 12 41 31

@sahar-fehri sahar-fehri added this pull request to the merge queue Nov 21, 2024
Merged via the queue into develop with commit ba11881 Nov 21, 2024
75 checks passed
@sahar-fehri sahar-fehri deleted the fix/fix-display-account-list-item-with-portfolio-view branch November 21, 2024 12:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The "Select an account" modal displays incorrect balances
6 participants