-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix account list item for portfolio view #28598
Merged
sahar-fehri
merged 2 commits into
develop
from
fix/fix-display-account-list-item-with-portfolio-view
Nov 21, 2024
Merged
fix: fix account list item for portfolio view #28598
sahar-fehri
merged 2 commits into
develop
from
fix/fix-display-account-list-item-with-portfolio-view
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
sahar-fehri
added
the
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
label
Nov 21, 2024
sahar-fehri
force-pushed
the
fix/fix-display-account-list-item-with-portfolio-view
branch
from
November 21, 2024 09:36
21e4f8d
to
7019e84
Compare
7 tasks
Builds ready [7019e84]
Page Load Metrics (1899 ± 98 ms)
Bundle size diffs
|
QA done , works as expected , LGTM |
salimtb
approved these changes
Nov 21, 2024
jonybur
approved these changes
Nov 21, 2024
NidhiKJha
approved these changes
Nov 21, 2024
sahar-fehri
deleted the
fix/fix-display-account-list-item-with-portfolio-view
branch
November 21, 2024 12:43
metamaskbot
added
the
release-12.9.0
Issue or pull request that will be included in release 12.9.0
label
Nov 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
release-12.9.0
Issue or pull request that will be included in release 12.9.0
team-assets
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes account list item wit Portfolio view feature flag.
Related issues
Fixes: #28592
Manual testing steps
Make sure you run the steps with AND without the PORTFOLIO_VIEW flag
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist