fix: fix coin-overview display when price setting is off

[sahar-fehri]

Description

Fixes display bug on coin overview and account list item when user toggles OFF the Show balance and token price checker setting

Related issues

Fixes: #28567

Manual testing steps

1. Go to settings turn off Show balance and token price checker
2. Go back to home page you should see correct balance in crypto
3. Click on account item menu and you should see balance in crypto
4. Go to settings and turn it ON and you should see correct fiat balance.
5. Go to settings and turn on the "show native token as main balance"
6. You should see balance in crypto
7. Go to settings and turn OFF "show native token as main balance" also turn OFF "Show balance and token price checker"
8. You should see balance in crypto

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [6ee9cec]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2153 ± 108 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1873	2749	2145	223	107
		domContentLoaded	1859	2666	2109	213	102
		load	1875	2752	2153	225	108
		domInteractive	28	267	54	52	25
		backgroundConnect	10	84	38	26	13
		firstReactRender	55	115	87	17	8
		getState	51	107	79	20	9
		initialActions	0	1	0	0	0
		loadScripts	1363	2059	1557	166	80
		setupStore	6	45	10	8	4
		uiStartup	2178	3131	2442	232	111

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 217 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[bergeron]

LGTM

before:

after:

[seaona]

Thank you for the fix, I also see it working on my end 🙏 One suggestion: I think we should add an e2e test that covers this flow, so this bug is not re-introduced in the future. What do you think?

fix-balance-fiat.mp4

[sahar-fehri]

Totally! Added an e2e on a followup fix here #28598 🙏

[seaona]

awesome, thank you @sahar-fehri ❤️