Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [POM] Migrate create snap account e2e tests to page object modal #27697

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Oct 8, 2024

Description

This PR migrates the create-snap-account e2e tests to the Page Object Model (POM) pattern, improving test stability and maintainability.

Changes include:

  • Migrate test create-snap-account.spec.ts to POM
  • Avoid several delays in the original function implementation
  • remove create single account testcase because we already test it in test/e2e/tests/account/create-remove-account-snap.spec.ts

Open in GitHub Codespaces

Related issues

Fixes: #27699

Manual testing steps

Check code readability, make sure tests pass.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner October 8, 2024 13:21
@github-actions github-actions bot added the team-ai AI team (for the Devin AI bot) label Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chloeYue chloeYue marked this pull request as draft October 8, 2024 13:21
@chloeYue chloeYue changed the title Migrate create-snap-account to POM test: Migrate create-snap-account to POM Oct 8, 2024
@chloeYue chloeYue self-assigned this Oct 8, 2024
@chloeYue chloeYue added the team-extension-platform Extension Platform team label Oct 8, 2024
@chloeYue chloeYue changed the title test: Migrate create-snap-account to POM test: [POM] Migrate create snap account e2e tests to page object modal Oct 8, 2024
Copy link

sonarqubecloud bot commented Oct 8, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [31c7b1d]
Page Load Metrics (1904 ± 110 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24823161727443213
domContentLoaded160226061878233112
load164326121904228110
domInteractive22271585325
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@chloeYue chloeYue marked this pull request as ready for review October 8, 2024 14:40
@chloeYue chloeYue added this pull request to the merge queue Oct 9, 2024
Merged via the queue into develop with commit 65e656c Oct 9, 2024
78 checks passed
@chloeYue chloeYue deleted the migrate-create-snap-account-to-pom branch October 9, 2024 12:59
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 9, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-ai AI team (for the Devin AI bot) team-extension-platform Extension Platform team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[POM] Migrate create snap account e2e tests to page object modal
4 participants