Skip to content

Commit

Permalink
test: [POM] Migrate create snap account e2e tests to page object modal (
Browse files Browse the repository at this point in the history
#27697)

## **Description**
This PR migrates the create-snap-account e2e tests to the Page Object
Model (POM) pattern, improving test stability and maintainability.

Changes include:
- Migrate test create-snap-account.spec.ts to POM
- Avoid several delays in the original function implementation
- remove create single account testcase because we already test it in
`test/e2e/tests/account/create-remove-account-snap.spec.ts `

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27155?quickstart=1)

## **Related issues**

Fixes: #27699

## **Manual testing steps**
Check code readability, make sure tests pass.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Chloe Gao <[email protected]>
  • Loading branch information
devin-ai-integration[bot] and chloeYue authored Oct 9, 2024
1 parent 583d400 commit 65e656c
Show file tree
Hide file tree
Showing 4 changed files with 208 additions and 354 deletions.
345 changes: 0 additions & 345 deletions test/e2e/accounts/create-snap-account.spec.ts

This file was deleted.

Loading

0 comments on commit 65e656c

Please sign in to comment.