Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky test Responsive UI Send Transaction from responsive window #27417

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Sep 26, 2024

Description

Before clicking Confirm, we wait until the transaction gas and amount are loaded to avoid any possible rerender.
We also login with balance validation, so we can get rid of the initial delay.

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/102392/workflows/75210923-91d6-44cc-b224-72f3f530dbb2/jobs/3815538/tests

Open in GitHub Codespaces

Related issues

Fixes: #27418

Manual testing steps

  1. Check ci
  2. Run test locally yarn test:e2e:single test/e2e/tests/responsive-ui/metamask-responsive-ui.spec.js --browser=chrome --leave-running=true

Screenshots/Recordings

Screenshot from 2024-09-26 12-18-20

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seaona seaona requested a review from a team as a code owner September 26, 2024 10:17
@seaona seaona self-assigned this Sep 26, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona added team-extension-platform flaky tests area-qa Relating to QA work (Quality Assurance) labels Sep 26, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [5ab38ed]
Page Load Metrics (1927 ± 108 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint164527151917228110
domContentLoaded160926701881221106
load164727161927225108
domInteractive14162433316
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for the fix !

@metamaskbot
Copy link
Collaborator

Builds ready [5522a43]
Page Load Metrics (1884 ± 99 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31622501810398191
domContentLoaded16032197186120498
load16112230188420699
domInteractive15106442311
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Sep 26, 2024

@seaona seaona merged commit 251b480 into develop Sep 26, 2024
76 of 77 checks passed
@seaona seaona deleted the responsive-ui-flaky branch September 26, 2024 17:40
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 26, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [7351963]
Page Load Metrics (1927 ± 172 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint61826891811387186
domContentLoaded147329061895358172
load148129391927359172
domInteractive22268545225
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-qa Relating to QA work (Quality Assurance) flaky tests release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fix "MetaMask Responsive UI Send Transaction from respons..." flaky tests
4 participants