-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: flaky test Responsive UI Send Transaction from responsive window
#27417
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [5ab38ed]
Page Load Metrics (1927 ± 108 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks for the fix !
Builds ready [5522a43]
Page Load Metrics (1884 ± 99 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
Builds ready [7351963]
Page Load Metrics (1927 ± 172 ms)
Bundle size diffs
|
Description
Before clicking Confirm, we wait until the transaction gas and amount are loaded to avoid any possible rerender.
We also login with balance validation, so we can get rid of the initial delay.
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/102392/workflows/75210923-91d6-44cc-b224-72f3f530dbb2/jobs/3815538/tests
Related issues
Fixes: #27418
Manual testing steps
yarn test:e2e:single test/e2e/tests/responsive-ui/metamask-responsive-ui.spec.js --browser=chrome --leave-running=true
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist