Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "MetaMask Responsive UI Send Transaction from respons..." flaky tests #27418

Closed
seaona opened this issue Sep 26, 2024 · 0 comments · Fixed by #27417
Closed

Fix "MetaMask Responsive UI Send Transaction from respons..." flaky tests #27418

seaona opened this issue Sep 26, 2024 · 0 comments · Fixed by #27417
Assignees
@seaona
Labels
flaky tests release-12.6.0 Issue or pull request that will be included in release 12.6.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform type-bug

Comments

@seaona
Copy link
Contributor

seaona commented Sep 26, 2024

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/102392/workflows/75210923-91d6-44cc-b224-72f3f530dbb2/jobs/3815538/tests
@seaona seaona added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform flaky tests labels Sep 26, 2024
@seaona seaona self-assigned this Sep 26, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Sep 26, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Sep 26, 2024
@seaona seaona mentioned this issue Sep 26, 2024
Merged
7 tasks
seaona added a commit that referenced this issue Sep 26, 2024
@seaona
fix: flaky test `Responsive UI Send Transaction from responsive windo…
251b480 
…w` (#27417)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Before clicking Confirm, we wait until the transaction gas and amount
are loaded to avoid any possible rerender.
We also login with balance validation, so we can get rid of the initial
delay.


https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/102392/workflows/75210923-91d6-44cc-b224-72f3f530dbb2/jobs/3815538/tests


[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27417?quickstart=1)

## **Related issues**

Fixes: #27418

## **Manual testing steps**

1. Check ci
2. Run test locally `yarn test:e2e:single
test/e2e/tests/responsive-ui/metamask-responsive-ui.spec.js
--browser=chrome --leave-running=true`

## **Screenshots/Recordings**

![Screenshot from 2024-09-26
12-18-20](https://github.com/user-attachments/assets/604b995f-7db0-4d52-b129-351d82d0831e)


## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Sep 26, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Sep 26, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seaona seaona

Labels
flaky tests release-12.6.0 Issue or pull request that will be included in release 12.6.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform type-bug
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: flaky test Responsive UI Send Transaction from responsive window MetaMask/metamask-extension
2 participants
@metamaskbot @seaona