Check if ledger was successfully able to establish transport on confirm screen mount #12535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
darkwing
reviewed
Oct 29, 2021
app/scripts/metamask-controller.js
Outdated
| @@ -1549,6 +1553,11 @@ export default class MetamaskController extends EventEmitter { | |||
| return keyring; | |||
| } | |||
|
|
|||
| async attemptLedgerTransportCreation() { | |||
| const keyring = this.getKeyringForDevice('ledger'); | |||
There was a problem hiding this comment.
This needs an await:
const keyring = await this.getKeyringForDevice('ledger');
There was a problem hiding this comment.
this is addressed since my latest rebase
danjm
force-pushed
the
ledger-connection-failure-warning
branch
from
d3f0b42 to
4d04e74
Compare
Builds ready [4d04e74]
Page Load Metrics (343 ± 40 ms)
highlights:storybook
|
danjm
force-pushed
the
ledger-connection-failure-warning
branch
from
a6239ea to
4a0d6bf
Compare
This was referenced Nov 2, 2021
Merged
… of confirm screens
danjm
force-pushed
the
ledger-connection-failure-warning
branch
from
e849811 to
e40d909
Compare
darkwing
approved these changes
Nov 4, 2021
ryanml
approved these changes
Nov 4, 2021
Builds ready [e40d909]
Page Load Metrics (581 ± 68 ms)
highlights:storybook
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Ledger users who connect with WebHID, on some operating systems the connection of the ledger device to other software can prevent the WebHID transport from successfully being created. This PR adds a message to the user if that state is detected.
Depends on MetaMask/eth-ledger-bridge-keyring#125 and MetaMask/eth-ledger-bridge-keyring#126