Allow the triggering of make-app via message #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 29, 2021
|
Still testing this but this will require a bundle update |
darkwing
reviewed
Oct 29, 2021
| @@ -47,6 +47,8 @@ export default class LedgerBridge { | |||
| this.updateTransportTypePreference(replyAction, 'u2f') | |||
| } | |||
| break | |||
| case 'ledger-make-app': | |||
| this.attemptMakeApp(replyAction); | |||
There was a problem hiding this comment.
This requires a break afterward.
danjm
commented
Nov 2, 2021
| @@ -91,6 +110,12 @@ export default class LedgerBridge { | |||
| this.app = new LedgerEth(this.transport) | |||
| } | |||
| } else if (this.transportType === 'webhid') { | |||
There was a problem hiding this comment.
This handles a pre-existing bug, but one that was only noticeable with the changes made in this PR
danjm
commented
Nov 3, 2021
| this.app = null | ||
| if (this.transport) { | ||
| this.transport.close() |
There was a problem hiding this comment.
This is a pre-existing issue, but also needed for this PR to work correctly
darkwing
approved these changes
Nov 3, 2021
ledger-bridge.js
Outdated
| } | ||
|
|
||
| async makeApp (config) { | ||
| config = config || {}; |
There was a problem hiding this comment.
Instead of this line, can we do:
async makeApp (config = {}) {
danjm
added a commit
that referenced
this pull request
Nov 3, 2021
… of error detection (#125) * Allow the triggering of make-app via message * Update bundle.js * Break on ledger-make-app inswitch * Don't create new webhid transport if it already exists and is open * Fix attemptMakeApp * Only attempt to open existing webhid device in attemptMakeApp * Use default parameter in makeApp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
'ledger-make-app'message, which calls a new wrapper around themakeAppmethod. This allows external callers to attempt to create a transport and device connection and then see whether that attempt succeeded or failed, decoupled from any action.