Fix #10010 - Fetch swap quote refresh time from API #10069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkwing
changed the title
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Gudahtt
reviewed
Dec 14, 2020
Gudahtt
reviewed
Dec 15, 2020
Gudahtt
reviewed
Dec 15, 2020
darkwing
force-pushed
the
10010-api-refresh-time-controller
branch
2 times, most recently
from
e5f2393 to
9595c93
Compare
Gudahtt
reviewed
Dec 15, 2020
Gudahtt
reviewed
Dec 15, 2020
| }, | ||
| } | ||
|
|
||
| const sandbox = sinon.createSandbox() | ||
| const fetchTradesInfoStub = sandbox.stub() | ||
| const fetchSwapsFeatureLivenessStub = sandbox.stub() | ||
| const fetchSwapsQuoteRefreshTimeStub = sandbox.stub() |
There was a problem hiding this comment.
Note that this stub isn't being reset correctly between tests, but we can solve that separately in a later PR. Might as well fix all of these stubs at once, since they all follow the same pattern.
darkwing
force-pushed
the
10010-api-refresh-time-controller
branch
2 times, most recently
from
03eefe3 to
911f580
Compare
darkwing
force-pushed
the
10010-api-refresh-time-controller
branch
from
911f580 to
24dd8fe
Compare
Gudahtt
approved these changes
Dec 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes: #10017
Fixes: #10010
The MetaSwap team has implemented a new endpoint which tells us how often quotes should refresh. We were hardcoding 60 seconds as the refresh value, but moving that value to the MetaSwap API would prevent the MetaMask team from needing to create and deploy a new release in each browser to adjust that value.
As to why I've gone this route to accomplish this functionality, I like this strategy because we aren't pinging MetaSwap until we absolutely need to (i.e. when we're fetching quotes to display). We also benefit from fetchWithCache caching that value, so that we aren't pinging MetaSwap each time. @cloudonshore had mentioned this value wouldn't often change, so a fetch with cache only when we need that value should make us performant.