Fix 10010 - Fetch swap quote refresh time from API #10017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
darkwing
force-pushed
the
10010-api-refresh-time
branch
from
313ff30 to
71d9290
Compare
darkwing
force-pushed
the
10010-api-refresh-time
branch
from
71d9290 to
a734732
Compare
darkwing
requested review from
danjm and
brad-decker
and removed request for
brad-decker
brad-decker
approved these changes
Dec 10, 2020
danjm
requested changes
Dec 11, 2020
There was a problem hiding this comment.
There is also some code in the swaps controller related to the refresh time that is currently hard coded. Look at the variable called QUOTE_POLLING_INTERVAL. It is set to 10 seconds less than the quote refresh time. So either we need to manage state for this in the background controller, or pass the value retrieved from the api to the fetchAndSetQuotes method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10010
The MetaSwap team has implemented a new endpoint which tells us how often quotes should refresh. We were hardcoding 60 seconds as the refresh value, but moving that value to the MetaSwap API would prevent the MetaMask team from needing to create and deploy a new release in each browser to adjust that value.
As to why I've gone this route to accomplish this functionality, I like this strategy because we aren't pinging MetaSwap until we absolutely need to (i.e. when we're fetching quotes to display). We also benefit from
fetchWithCachecaching that value, so that we aren't pinging MetaSwap each time. @cloudonshore had mentioned this value wouldn't often change, so a fetch with cache only when we need that value should make us performant.