Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide converted price of token if no conversion rate found #4661

Closed
danjm opened this issue Jun 25, 2018 · 2 comments
Closed

Hide converted price of token if no conversion rate found #4661

danjm opened this issue Jun 25, 2018 · 2 comments
Assignees
Labels
area-UI Relating to the user interface. good first issue Good for newcomers type-enhancement

Comments

@danjm
Copy link
Contributor

danjm commented Jun 25, 2018

Currently on the send screen, if we do not have currency conversion data for a token, we show represent the converted amount as 0 in whatever the users selected currency is. For example, see the '$0.00 USD' in the screenshots of #4645

If we do not have currency conversion information, we simply should not show a converted currency.

@danjm danjm added the area-UI Relating to the user interface. label Jun 25, 2018
@danjm danjm self-assigned this Jun 25, 2018
@danjm
Copy link
Contributor Author

danjm commented Jul 6, 2018

To replicate:

  • switch to ropsten network
  • go to https://faucet.metamask.io/ and request 1 ether from faucet
  • go to https://tokenfactory.surge.sh/#/ and create token contract (e.g. Enter: 100, ABC, 0, ABC to keep things simple)
  • once the token is created, copy the contract address
  • back in metamask, click "Add Token"
  • click the "Custom Token" tab and copy the address of the token you just created, the other fields should autopopulate
  • click Next and Next
  • select the newly created token in the sidebar
  • click 'Send'

You will see the above describe issue on the send screen

whymarrh added a commit that referenced this issue Jul 17, 2018
Fixes conversion status for tokens without conversion rates (#4661)
@snreynolds
Copy link

Closed with #4777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface. good first issue Good for newcomers type-enhancement
Projects
None yet
Development

No branches or pull requests

2 participants