Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Token - Formatting and UI issues on Firefox / Apple Mac (BETA) #4645

Closed
prographo opened this issue Jun 22, 2018 · 3 comments
Closed

Send Token - Formatting and UI issues on Firefox / Apple Mac (BETA) #4645

prographo opened this issue Jun 22, 2018 · 3 comments
Labels
area-UI Relating to the user interface. type-bug

Comments

@prographo
Copy link

prographo commented Jun 22, 2018

I created a custom 'MART' token to test this. Go to the Send Token screen on Metamask BETA.

See attached screenshot #1.

a) It says "insufficient funds", I don't know why - if there is zero, it should say zero - infact there are 1000 MART tokens (which it determined correctly on the screen previous to this).

See attached screenshot #2. -- Once I click "up" arrow on amount field the "insufficient funds" message goes away, and is replaced with 0.

b) There is not width to display the number, the number should say 22, but as you can see, it only shows part.

c) There is a USD amount under the token amount - does this make sense - I guess you are dynamically looking up the price somehow, maybe if you can't find a price, it should say that - idk.

d) In screenshot #1) the Gas Fee section it has calculated 0.0152 ETH to do the send ($7.08), don't know how it got to that, but obviously that is waaaaaay too high. In screenshot #2) it has (inexplicably halved that estimate - still waaaaay too high. Strangely once I pasted in the destination address, it recalculated to 0.000000004 ETH / $0.14 and I sent the transaction without problems. screenshot #3.

screen shot 2018-06-22 at 14 38 35

screen shot 2018-06-22 at 14 43 51

screen shot 2018-06-22 at 14 56 58

  • Browser Used
    Firefox
  • Operating System Used
    Apple Mac
@bdresser bdresser added type-bug area-UI Relating to the user interface. labels Jun 22, 2018
@bdresser
Copy link
Contributor

thanks @prographo. we're in the process of refactoring the confirm screen on the new UI so this may be addressed as part of that work (#4404). heads up @alextsg

@danjm
Copy link
Contributor

danjm commented Jun 25, 2018

@prographo Thanks a lot for filing these issues. You are correct that there are a lot of improvements that can be made here:

(b) Is fixed by an already in review PR: #4647

For the other issues you've addressed I have created tickets that outline solutions:

(a) #4660
(c) #4661
(d) #4662

(d) is probably also partially a result of a gas price estimation bug that will likely be resolved with #4615

@bdresser
Copy link
Contributor

bdresser commented Aug 3, 2018

various issues mentioned here have been broken into separate tickets, outlined above. closing this one~

@bdresser bdresser closed this as completed Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface. type-bug
Projects
None yet
Development

No branches or pull requests

3 participants