-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speeding up EIP-1559 transactions always results in failure #11974
Comments
I'm not able to reproduce the error after trying speed up transactions several times. I'm on Chrome, MetaMask version 10.0.3. What network are you trying this on? Can you include a screenshot of your console error? |
I'm getting this error when I try to speed up txns too. There is no error in console. There is just an error that appears in the OS notification, and there is no way to read the full error. I've tried sending a new txn manually with the same nonce as my stuck txn, but that fails too. Is there another wallet I can use to import my private key and unstick my transactions? I got it to unstick by just setting my gas price crazy high on the new txn to 2000 gwei and 100 priority fee. I think if the replacement txn being submitted has too low of a gas fee metamask throws unexpected errors. |
@Zaphod101010 is this happening when you're performing a swap? |
It wasn't a swap. The stuck txn was the mint function on one of the loot derivatives. |
@Zaphod101010 @beaugunderson What version of MetaMask are you using? |
Oh, I see @beaugunderson is on 10.0.3 |
@beaugunderson @Zaphod101010 @BlackDots If you are willing, it would be helpful if you could grab your state logs and securely submit them to us via our customer support channel.s
|
v10.0.3 |
Two friends just reported that speedups failed on transactions as well; here's one example where a speedup failed: https://etherscan.io/tx/0x202eb0c9929db5a5ed1400308d8a25219e5ae405c48f3666a8fac11ba57dea55 |
hmm, |
I submitted the state log for the specific transaction in question; if you need more let me know 👍 |
this is the full error, btw:
|
I'm having the same problem. I managed to submit one speed-up, but it doesn't show up in Etherscan. When I try to submit another, I get the RPC error. |
I've got the same issue, Metamask 10.1.0 for Firefox |
Same issue in firefox. Speed up doesn't work and no new transaction appears. |
@kevinghim |
This annoying and disgusting bug still exists. 10.5.2 |
This happens to me consistently too. Not when using the built-in "Speed up" feature though. But each and every time when I create a new fresh transaction and manually set it to the same nonce as the previous one. |
## **Description** Our fork of ethjs-query has been namespaced to the `@metamask/` namespace, and updated with mostly development only fixes. There is one exception which is the reason for this pull request which is the removal of a try/catch that was catching too broadly and wrapping legitimate errors in a new Error object that claimed the issue was with the formatting of the output. In most cases this is incorrect and results in a wide swath of errors being lumped together inside of sentry. This change will result in the real errors being surfaced, after which we can decide where to prioritize efforts to resolve RPC issues. This PR progresses, and is expected to change the stack trace for the following issues: #9317 #10519 #10619 #11488 #11974 #13395 #14298 #14365 #15250 #17073 #17803 #19697 #20699 We are closing these issues opened automatically by sentry-io which are not fully resolved but should result in better errors and stack traces: fixes #10552 fixes #14660 fixes #14676 fixes #14730 fixes #14801 fixes #15065 ## **Manual testing steps** 1. Attempt to reproduce any of the bugs listed, 17073 was the easiest to reproduce for me. This involves getting test currency from the wemix faucet as listed in the issue and initiating a transaction between two accounts you own. 2. On develop you'll see an 'error formatting outputs' error text similar to what is reported in the issue. 3. On this branch you'll get the original error, without the wrapped 'formatting' error. including a different stack trace. ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained: - [x] What problem this PR is solving. - [x] How this problem was solved. - [x] How reviewers can test my changes. - [x] I’ve indicated what issue this PR is linked to: Fixes #??? - [x] I’ve included tests if applicable. - [x] I’ve documented any added code. - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <[email protected]>
Describe the bug
I always get this error when speeding up an EIP-1559 transaction, and no replacement transaction is sent:
Steps to reproduce (REQUIRED)
Expected behavior
Screenshots
See above
Browser details (please complete the following information):
Additional context (Error Messages, etc.)
What would be helpful?
The text was updated successfully, but these errors were encountered: