chore: update align dependencies and update build scripts in design tokens #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@lavamoat/[email protected], npm/[email protected] |
georgewrmarshall
changed the title
| @@ -3,44 +3,18 @@ | |||
| * https://jestjs.io/docs/configuration | |||
There was a problem hiding this comment.
Updating jest config to align with packages jest config
Comment on lines
-20
to
+27
| "types": "./dist/types/index.d.ts", | ||
| "import": "./dist/index.mjs", | ||
| "require": "./dist/index.js" | ||
| "import": { | ||
| "types": "./dist/index.d.mts", | ||
| "default": "./dist/index.mjs" | ||
| }, | ||
| "require": { | ||
| "types": "./dist/index.d.cts", | ||
| "default": "./dist/index.cjs" | ||
| } |
There was a problem hiding this comment.
Updating to align with packages we are not changing the exports because we are still exporting the types folder on line 34
| "build": "tsup --clean && yarn build:types && yarn build:css", | ||
| "build-storybook": "storybook build", | ||
| "build:clean": "rimraf dist && yarn build", | ||
| "build": "ts-bridge --project tsconfig.build.json --verbose --clean --no-references && yarn build:css", |
There was a problem hiding this comment.
Updating build to use ts-bridge and align with other packages, I assume types get build as well but keeping the css build
| "tsup": "^7.2.0", | ||
| "typescript": "~5.2.2", | ||
| "vite": "^5.2.10" | ||
| "typescript": "~5.2.2" |
There was a problem hiding this comment.
Removing all unneeded dependencies but keeping typescript to align with other packages package.json
brianacnguyen
previously approved these changes
Nov 14, 2024
georgewrmarshall
force-pushed
the
fix/108/update-build-scripts
branch
from
13ff039
to
a0c3ad1
Compare
brianacnguyen
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves Issue #108 by aligning the dependencies and build scripts in the target package with the monorepo's root configuration as part of the design tokens migration process. Following the Package Migration Process Guide
Related issues
Fixes: #108
Manual testing steps
Pre-merge author checklist
Pre-merge reviewer checklist