Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate design tokens: Align dependencies and build scripts with monorepo #108

Closed
georgewrmarshall opened this issue Nov 13, 2024 · 0 comments · Fixed by #115
Closed

migrate design tokens: Align dependencies and build scripts with monorepo #108

georgewrmarshall opened this issue Nov 13, 2024 · 0 comments · Fixed by #115
Assignees

Comments

@georgewrmarshall
Copy link
Contributor

Description

As part of the design tokens migration, this task involves aligning the dependencies and build scripts in the target package with the monorepo's root configuration. This step will help eliminate redundancy, ensure compatibility, and maintain version consistency across the monorepo.

Technical Details

  • Remove Redundant Scripts:

    • Remove any build scripts from the target package's package.json that are already present in the root package.json, including prepack.
  • Remove Redundant Dependencies:

    • Remove any dependencies from the target package's package.json that are already listed in the root package.json.
    • Exception: Retain TypeScript even if listed in the root.
  • Align Dependency Versions:

    • Internal Dependencies (i.e., other sub-packages within the monorepo):
      • Bump the target package dependency version to match the monorepo if it’s behind.
    • External Dependencies:
      • If the target dependency version is ahead, decrement it to align with the monorepo.
      • If it’s behind, bump only if this change does not introduce breaking changes.
  • Reference:

    • Refer to Example PR for guidance on handling dependency alignment and build script removal.

Acceptance Criteria

  • All redundant build scripts are removed from the target package’s package.json.
  • All redundant dependencies are removed from the target package’s package.json, except for TypeScript.
  • Dependency versions in the target package are aligned with the monorepo, following the outlined criteria for version adjustments.
  • Builds and tests function correctly across packages with updated dependencies and scripts.

References

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant