This repository has been archived by the owner on Nov 9, 2023. It is now read-only.
Fix notification response.id check #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanejonas
reviewed
May 17, 2021
| @@ -63,7 +63,7 @@ export default function createStreamMiddleware() { | |||
| ) { | |||
| let err; | |||
| try { | |||
| const isNotification = !res.id; | |||
| const isNotification = !('id' in res); | |||
There was a problem hiding this comment.
isNotification will be false if res.id === null.
|
Superseded by #24. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A JSON-RPC notification is defined as a JSON-RPC request whose
idfield is missing. Specifically:The number
0is a valid ID, but this package will currently erroneously identify requests withid: 0as notifications. We should fix this.Note: Should not be merged until
idvalidation is added tojson-rpc-engine.