Skip to content
This repository has been archived by the owner on Nov 9, 2023. It is now read-only.

Add DuplexJsonRpcEngine stream #24

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

rekmarks
Copy link
Member

WIP.

@rekmarks rekmarks requested a review from a team as a code owner July 17, 2022 02:13
@rekmarks rekmarks marked this pull request as draft July 17, 2022 02:14
@rekmarks rekmarks changed the base branch from main to repository-standardization July 17, 2022 02:14
@rekmarks rekmarks force-pushed the duplex-engine-stream branch from ef3ed41 to 32939e3 Compare July 20, 2022 05:25
Base automatically changed from repository-standardization to main July 26, 2022 23:22
rekmarks added a commit that referenced this pull request Jul 26, 2022
Standardizes this repository per the module template as of Q3 2022. All changes are copied over directly from the template, except for the tests, which have been rewritten. A couple of notes:
- I didn't bother rewriting the tests for JSON-RPC notifications, as that functionality will be implemented in a completely different manner in #24 has been merged.
- CI has been switched from CircleCI to GitHub Actions.
@legobeat
Copy link
Contributor

@rekmarks Is there a path forward here?

@legobeat
Copy link
Contributor

legobeat commented Sep 4, 2023

@rekmarks

@MajorLift
Copy link
Contributor

This library has now been migrated into the core monorepo. This PR has been locked and this repo will be archived shortly. Going forward, releases of this library will only include changes made in the core repo.

  • Please push this branch to core and open a new PR there.
  • Optionally, add a link pointing to the discussion in this PR to provide context.

@MetaMask MetaMask locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants