Support bip 44 + tests #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianariel
referenced
this pull request
in block-wallet/eth-ledger-bridge-keyring
Apr 27, 2022
Support bip 44 + tests
dawnseeker8
added a commit
that referenced
this pull request
Jun 24, 2024
* feat: add mobile keyring bridge * chore: update version number * feat: upgrade @ethereumjs/tx library to match the same version used in TransactionController 8.0.1 to fix all transaction broken issue. Fix the signPersonalMessage in ledger always return 0x0 in v value in test-dapp * feat: upgrade ledgerHQ library to latest to resolve vulnerablity report from socket-security * Feat/add mobile keyring bridge flat version (#3) * feat: this is a backup of flat directory version of eth-ledger-bridge-keyring to successfully solve the metamask-mobile not able to resovle all the module under the subdirectory during build process. * feat: improve the unit tests coverage for some API. * feat: run `yarn lint:fix` and update the correct import in index.ts file. * feat: add unit tests coverage * feat: fix lint error in test file. * feat: Remove unit tests which failed. * feat: Add extra test to cover more lines in ledger-keyring.ts * feat: Add yarn lint:fix * feat: Increase the threshold coverage to pass the pipeline. * feat: revert the version of package.. * Update src/ledger-transport-middleware.ts Co-authored-by: Gustavo Antunes <[email protected]> * Update src/ledger-mobile-bridge.test.ts Co-authored-by: Gustavo Antunes <[email protected]> * Update src/ledger-mobile-bridge.test.ts Co-authored-by: Gustavo Antunes <[email protected]> * Update src/ledger-mobile-bridge.test.ts Co-authored-by: Gustavo Antunes <[email protected]> * Apply suggestions from code review Co-authored-by: Gustavo Antunes <[email protected]> * feat: remove the comment code in `prepack.sh` * feat: change the jsDoc for deviceSignMessage method. * feat: fix the lint issue. * Apply suggestions from code review Co-authored-by: Gustavo Antunes <[email protected]> * Apply suggestions from code review Co-authored-by: Gustavo Antunes <[email protected]> * feat: change setAccountToUnlock method signature to enforce index is number type. * feat: change setAccountToUnlock method signature to enforce index is number type. * feat: commit the new coverageThreshold to pass the test. --------- Co-authored-by: Xiaoming Wang <[email protected]> Co-authored-by: Gustavo Antunes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.