feat: add mobile keyring bridge #225

stanleyyconsensys · 2024-03-28T10:34:40Z

Description

This PR adds the mobile ledger bridge into the eth-ledger-bridge-keyring. The mobile ledger bridge shares the same interface as the ledger iframe bridge. This changes decouples the previous code into 3 parts,

mobile-ledger-bridge.ts: Component to use the same interface as the ledger iframe bridge
mobile-ledger-bridge/middleware: Component to wrap the bluetooth transport layer and the eth app layer
mobile-ledger-bridge/ledger-hw-app: Extended from the ledger eth app, this component offers some extra methods to the ledger hardware, such as open eth app, get name, and version of the current app

Related Issues

fixes: #228

…n TransactionController 8.0.1 to fix all transaction broken issue. Fix the signPersonalMessage in ledger always return 0x0 in v value in test-dapp

…rt from socket-security

socket-security · 2024-03-28T11:25:36Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@babel/[email protected]	environment	`+10`	184 kB	nicolo-ribaudo
npm/@babel/[email protected]	environment, filesystem, unsafe Transitive: shell	`+23`	4.56 MB	nicolo-ribaudo
npm/@babel/[email protected]	None	`+3`	624 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	11.7 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	1.88 MB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	68.9 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`+5`	701 kB	nicolo-ribaudo
npm/@babel/[email protected]	environment	`+3`	2.5 MB	nicolo-ribaudo
npm/@eslint-community/[email protected]	None	`0`	431 kB	eslint-community-bot
npm/@jridgewell/[email protected]	None	`0`	53.2 kB	jridgewell
npm/@jridgewell/[email protected]	None	`0`	169 kB	jridgewell
npm/@ledgerhq/[email protected]	None	`0`	195 kB	ldg-github-ci
npm/@ledgerhq/[email protected]	Transitive: environment, network	`+24`	9.21 MB	gre
npm/@ledgerhq/[email protected]	None	`+3`	4.92 MB	ldg-github-ci
npm/@ledgerhq/[email protected]	None	`0`	36.3 kB	sergii-shkolin
npm/@ledgerhq/[email protected]	None	`0`	71.4 kB	ldg-github-ci
npm/@ledgerhq/[email protected]	None	`0`	30.9 kB	ldg-github-ci
npm/@metamask/[email protected]	Transitive: filesystem	`+7`	730 kB	metamaskbot
npm/@metamask/[email protected]	None	`+4`	697 kB	metamaskbot
npm/@metamask/[email protected]	None	`+6`	1.6 MB	metamaskbot
npm/@noble/[email protected]	None	`+1`	2.15 MB	paulmillr
npm/@scure/[email protected]	None	`0`	80.4 kB	paulmillr
npm/@types/[email protected]	None	`0`	84.1 kB	types
npm/@types/[email protected]	None	`0`	4.3 kB	types
npm/@types/[email protected]	None	`0`	5.45 kB	types
npm/@types/[email protected]	None	`0`	1.8 MB	types
npm/[email protected]	None	`0`	531 kB	marijn
npm/[email protected]	network	`0`	31.2 kB	tootallnate
npm/[email protected]	None	`+4`	87.8 kB	ljharb
npm/[email protected]	None	`+2`	50.4 kB	ljharb
npm/[email protected]	filesystem, unsafe Transitive: environment, eval	`+50`	7.87 MB	rumpl
npm/[email protected]	None	`+46`	3.37 MB	ljharb
npm/[email protected]	None	`0`	12.3 kB	ljharb
npm/[email protected]	None	`0`	11 kB	ljharb
npm/[email protected]	filesystem, unsafe Transitive: environment	`+19`	1.95 MB	ljharb
npm/[email protected]	filesystem	`0`	325 kB	simenb
npm/[email protected]	environment, filesystem Transitive: eval, unsafe	`+61`	8.2 MB	eslintbot
npm/[email protected]	None	`+2`	517 kB	paulmillr
npm/[email protected]	filesystem	`+6`	263 kB	mrmlnc
npm/[email protected]	eval	`+1`	73.1 kB	ljharb
npm/[email protected]	Transitive: environment, shell	`+18`	1.53 MB	isaacs
npm/[email protected]	None	`+1`	22.7 kB	ljharb
npm/[email protected]	None	`0`	12 kB	ljharb
npm/[email protected]	None	`0`	17.6 kB	ljharb
npm/[email protected]	None	`+1`	40.2 kB	ljharb
npm/[email protected]	None	`0`	51.5 kB	kael
npm/[email protected]	None	`0`	30.2 kB	ljharb
npm/[email protected]	None	`0`	18.7 kB	ljharb
npm/[email protected]	None	`0`	34.4 kB	oss-bot
npm/[email protected]	filesystem	`0`	533 kB	isaacs
npm/[email protected]	Transitive: environment, filesystem	`+13`	171 kB	matzkoh
npm/[email protected]	environment, filesystem	`+2`	159 kB	ljharb
npm/[email protected]	None	`+1`	110 kB	npm-cli-ops
npm/[email protected]	network	`+4`	558 kB	joshglazebrook
npm/[email protected]	environment, filesystem, unsafe	`+12`	1.39 MB	blakeembrey
npm/[email protected]	None	`0`	73.1 kB	ethan_arrowood
npm/[email protected]	None	`+4`	92.7 kB	ljharb

View full report↗︎

* feat: this is a backup of flat directory version of eth-ledger-bridge-keyring to successfully solve the metamask-mobile not able to resovle all the module under the subdirectory during build process. * feat: improve the unit tests coverage for some API. * feat: run `yarn lint:fix` and update the correct import in index.ts file.

socket-security · 2024-04-29T02:22:01Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

scripts/prepack.sh

src/ledger-transport-middleware.ts

src/ledger-mobile-bridge.ts

src/ledger-mobile-bridge.test.ts

Co-authored-by: Gustavo Antunes <[email protected]>

gantunesr

Hey @dawnseeker8, I left a lot of suggestions about the test names in accordance to our guidelines. The code is looking good so far.

https://github.com/MetaMask/contributor-docs/blob/main/docs/e2e-testing.md#guidelines

src/ledger-hw-app.test.ts

src/ledger-keyring.test.ts

Co-authored-by: Gustavo Antunes <[email protected]>

…number type.

dawnseeker8 · 2024-06-24T15:27:23Z

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package Note Source CI
New author npm/[email protected]

New Author: npm-cli-ops

Previous Author: gar

orphan: npm/[email protected]

🚫
New author npm/[email protected]

New Author: lukekarrys

Previous Author: isaacs

orphan: npm/[email protected]

🚫
New author npm/[email protected]

New Author: ralxz

Previous Author: holgerd77

package.json

🚫
New author npm/@npmcli/[email protected]

New Author: gar

Previous Author: lukekarrys

package.json

🚫
Deprecated npm/@npmcli/[email protected]

Reason: This functionality has been moved to @npmcli/fs

package.json

🚫
New author npm/[email protected]

New Author: lukekarrys

Previous Author: zkat

package.json

🚫
New author npm/[email protected]

New Author: npm-cli-ops

Previous Author: nlf

package.json

🚫
New author npm/[email protected]

New Author: lukekarrys

Previous Author: rvagg

package.json

🚫
New author npm/[email protected]

New Author: npm-cli-ops

Previous Author: lukekarrys

package.json

🚫
New author npm/[email protected]

New Author: vscode-bot

Previous Author: aeschli

package.json

🚫
New author npm/[email protected]

New Author: explodingcabbage

Previous Author: kpdecker

package.json

🚫
New author npm/[email protected]

New Author: artmllr

Previous Author: ianstormtaylor

package.json

🚫
Network access npm/[email protected]

Module: net

Location: Package overview

orphan: npm/[email protected]

🚫
Network access npm/[email protected]

Module: http

Location: Package overview

Source

🚫
Network access npm/[email protected]

Module: https

Location: Package overview

Source

🚫
Network access npm/[email protected]

Module: net

Location: Package overview

Source

🚫
Network access npm/@npmcli/[email protected]

Module: net

Location: Package overview

orphan: npm/@npmcli/[email protected]

🚫
Network access npm/@npmcli/[email protected]

Module: tls

Location: Package overview

orphan: npm/@npmcli/[email protected]

🚫
Network access npm/@npmcli/[email protected]

Module: dns

Location: Package overview

orphan: npm/@npmcli/[email protected]

🚫
Network access npm/@npmcli/[email protected]

Module: http-proxy-agent

Location: Package overview

orphan: npm/@npmcli/[email protected]

🚫
Network access npm/@npmcli/[email protected]

Module: https-proxy-agent

Location: Package overview

orphan: npm/@npmcli/[email protected]

🚫
View full report↗︎

Next steps

** What is new author? **
** What is a deprecated package? **
** What is network access? **
This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

** Take a deeper look at the dependency **
** Remove the package **
If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

@SocketSecurity ignore-all

dawnseeker8 · 2024-06-24T15:32:27Z

@SocketSecurity ignore-all

stanleyyconsensys added 2 commits March 28, 2024 18:32

feat: add mobile keyring bridge

42e8291

chore: update version number

0cecf35

stanleyyconsensys requested a review from a team as a code owner March 28, 2024 10:34

dawnseeker8 added 2 commits March 28, 2024 10:52

feat: upgrade @ethereumjs/tx library to match the same version used i…

7375fa0

…n TransactionController 8.0.1 to fix all transaction broken issue. Fix the signPersonalMessage in ledger always return 0x0 in v value in test-dapp

feat: upgrade ledgerHQ library to latest to resolve vulnerablity repo…

a830897

…rt from socket-security

dawnseeker8 added 3 commits April 26, 2024 07:43

feat: add unit tests coverage

ef871ab

Merge branch 'main' into feat/add-mobile-keyring-bridge

366eeb7

dawnseeker8 added 6 commits April 29, 2024 03:29

feat: fix lint error in test file.

549d558

feat: Remove unit tests which failed.

dde4f28

feat: Add extra test to cover more lines in ledger-keyring.ts

2651a04

feat: Add yarn lint:fix

2d24e3c

feat: Increase the threshold coverage to pass the pipeline.

eee90ec

feat: revert the version of package..

4b6a5da

angelcheung22 added the team-hardware-wallets label May 6, 2024

gantunesr reviewed Jun 13, 2024

View reviewed changes

dawnseeker8 and others added 8 commits June 14, 2024 11:44

Update src/ledger-transport-middleware.ts

c106d7b

Co-authored-by: Gustavo Antunes <[email protected]>

Update src/ledger-mobile-bridge.test.ts

d25cec3

Co-authored-by: Gustavo Antunes <[email protected]>

Update src/ledger-mobile-bridge.test.ts

1ba9939

Co-authored-by: Gustavo Antunes <[email protected]>

Update src/ledger-mobile-bridge.test.ts

d3fa752

Co-authored-by: Gustavo Antunes <[email protected]>

Apply suggestions from code review

70518bd

Co-authored-by: Gustavo Antunes <[email protected]>

feat: remove the comment code in prepack.sh

4d68c85

feat: change the jsDoc for deviceSignMessage method.

84d2805

feat: fix the lint issue.

3e326de

dawnseeker8 requested a review from gantunesr June 18, 2024 13:07

gantunesr added the team-accounts label Jun 19, 2024

gantunesr assigned dawnseeker8 Jun 19, 2024

gantunesr reviewed Jun 19, 2024

View reviewed changes

dawnseeker8 and others added 4 commits June 20, 2024 09:35

Apply suggestions from code review

af27ce6

Co-authored-by: Gustavo Antunes <[email protected]>

Apply suggestions from code review

aed3826

Co-authored-by: Gustavo Antunes <[email protected]>

feat: change setAccountToUnlock method signature to enforce index is …

d5f1812

…number type.

feat: change setAccountToUnlock method signature to enforce index is …

062e961

…number type.

dawnseeker8 requested a review from gantunesr June 20, 2024 12:31

feat: commit the new coverageThreshold to pass the test.

54419ad

gantunesr approved these changes Jun 24, 2024

View reviewed changes

dawnseeker8 merged commit 8979b63 into MetaMask:main Jun 24, 2024
19 checks passed

dawnseeker8 deleted the feat/add-mobile-keyring-bridge branch June 24, 2024 16:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add mobile keyring bridge #225

feat: add mobile keyring bridge #225

stanleyyconsensys commented Mar 28, 2024 •

edited by gantunesr

Loading

socket-security bot commented Mar 28, 2024 •

edited

Loading

socket-security bot commented Apr 29, 2024 •

edited

Loading

gantunesr left a comment •

edited

Loading

dawnseeker8 commented Jun 24, 2024

Next steps

dawnseeker8 commented Jun 24, 2024

feat: add mobile keyring bridge #225

feat: add mobile keyring bridge #225

Conversation

stanleyyconsensys commented Mar 28, 2024 • edited by gantunesr Loading

Description

Related Issues

socket-security bot commented Mar 28, 2024 • edited Loading

socket-security bot commented Apr 29, 2024 • edited Loading

Next steps

gantunesr left a comment • edited Loading

Choose a reason for hiding this comment

dawnseeker8 commented Jun 24, 2024

Next steps

dawnseeker8 commented Jun 24, 2024

stanleyyconsensys commented Mar 28, 2024 •

edited by gantunesr

Loading

socket-security bot commented Mar 28, 2024 •

edited

Loading

socket-security bot commented Apr 29, 2024 •

edited

Loading

gantunesr left a comment •

edited

Loading