Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Cleanup test #82

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Cleanup test #82

merged 2 commits into from
Jan 18, 2023

Conversation

adonesky1
Copy link
Contributor

Addresses feedback left in this comment: #81 (comment)

@adonesky1 adonesky1 requested a review from a team as a code owner January 18, 2023 03:07
@adonesky1 adonesky1 requested a review from Gudahtt January 18, 2023 03:07
Gudahtt
Gudahtt previously approved these changes Jan 18, 2023
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

It'd be great to get rid of the constructor in the top-level beforeEach as well, but this is a good step forward.

@adonesky1
Copy link
Contributor Author

@Gudahtt I've removed the top level beforeEach

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adonesky1 adonesky1 merged commit 13682a9 into main Jan 18, 2023
@adonesky1 adonesky1 deleted the cleanup-test branch January 18, 2023 16:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants