This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Revert mnemonic serialization format #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
force-pushed
the
revert-mnemonic-serialization-format
branch
from
015a163 to
4e52067
Compare
adonesky1
commented
Jan 17, 2023
| @@ -228,7 +234,7 @@ describe('hd-keyring', () => { | |||
| expect(accountsSecondCheck[1]).toStrictEqual(secondAcct); | |||
| expect(accountsSecondCheck).toHaveLength(2); | |||
| const serialized = await keyring.serialize(); | |||
| expect(keyring._uint8ArrayToString(serialized.mnemonic)).toStrictEqual( | |||
| expect(Buffer.from(serialized.mnemonic).toString()).toStrictEqual( | |||
There was a problem hiding this comment.
this is simply reverting this change
Gudahtt
reviewed
Jan 17, 2023
| keyring.mnemonic.toString(), | ||
| ); | ||
| beforeEach(() => { | ||
| keyring = new HdKeyring({ |
There was a problem hiding this comment.
Nit: Rather than introduce a new beforeEach, it'd probably be better to move this step into each test instead. Setup within each test allows customization, avoiding this scenario we're in here where setup steps get repeated (e.g. here the constructor is getting called twice; three times for some tests).
There was a problem hiding this comment.
Whoops! PR to address this here
This was referenced Jan 18, 2023
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @Gudahtt 's here we want to revert the serialization format from
Uint8Arraysbecause they don't serialize nicely to JSON and we want to avoid any possible issues that arise there, back to an untyped array.This format was previously changed here and released with
v5.0.0