Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue33 - default queue name change. #1128

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Issue33 - default queue name change. #1128

merged 6 commits into from
Jul 17, 2024

Conversation

petersilva
Copy link
Contributor

fix #33

  • adds: queueShare setting, defaulting to ${USER}_${HOSTNAME}
  • essentially queueShare should be used wherever one used to set queueNames... should be no more need for queueName, and more often than before, the default should be good enough so queueName setting can just be removed.
  • changes default queue to end in queueShare, replacing the random-ids.
  • add RAND8 variable for people to use queueShare to get the old behaviour back by putting queueShare ${RAND8}_${RAND8} in their configuration.
  • documenting above.

petersilva and others added 3 commits July 16, 2024 17:48
Add the queueShare setting, and use it as part of the queue name,
replacing the use of random ids by a ${USER}_${HOSTNAME} for easier
troubleshooting. also add ${RAND8} to enable explicit setting
of queueShare to get the old default if need be.
Copy link

github-actions bot commented Jul 17, 2024

Test Results

244 tests   243 ✅  1m 6s ⏱️
  1 suites    1 💤
  1 files      0 ❌

Results for commit 54fc84f.

♻️ This comment has been updated with latest results.

@petersilva
Copy link
Contributor Author

after discussion adding _${RAND8} to default value.

@petersilva petersilva marked this pull request as ready for review July 17, 2024 16:28
@petersilva
Copy link
Contributor Author

OK... it looks good.

  • as per discussion: queueShare defaults to ${USER}_${HOSTNAME}_${RAND8},
  • separator is period.
  • documentation in both languages consistent with that.
  • documentation modified to promote use of queueShare, where queueName would have been used before.
  • unit tests updated, so they pass.

Copy link

@junhu3 junhu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally!

@petersilva petersilva merged commit 89f2eca into development Jul 17, 2024
4 checks passed
@petersilva petersilva deleted the issue33 branch August 9, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sr - add hostname on default queue name
2 participants