-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shared keyword and queue name defaults. #1077
Comments
@junhu3 @reidsunderland @andreleblanc11 comments? |
an alternative might be a string variable "scope"
|
I'm not sure if a whole new config options, maybe just define an environment variable? in default.conf:
in some configs, we'd set QUEUENAME_SUFFIX to The other special case is polls, where we have to use |
We could get FYI : I haven't gone through the code. Just throwing ideas in the dark. |
in v2, we did a lot of that sort of defaulting stuff... and it got confusing, so have veered away from it in sr3. I'll try digging up some old examples so we can talk it over a bit. |
fwiw... @andreleblanc11 the code that implements ... uh.. I'lll call them inferred? defaults is here: in sr3: It's in the config.py finalize() routine: https://github.com/MetPX/sarracenia/blob/development/sarracenia/config.py#L1861-L2014 in v2... it looks like it's in routines called check() ... about a dozen of them. in v2 we would do things like guess the post_broker from the broker... I don't remember |
Did this just get resolved with #1128? |
yeah... you're right... this is the same problem ... resolved by the above bug solution. |
So people have queueName in many, many, many configurations only because
the default does not have the hostname in it. but removing the hostname will cause
all cases where queues are shared to be broken, and just move the queueName declaration from one place to another.
Suggestion:
shared flag (default yes)
queueName defaults to q_${BROKER_USER}_${PROGRAM}.${WHERE}.${CONFIG}
So then people just have shared yes/no in the cluster name.
So this will make it so that the queues never have the random stuff at the end, but
we have a lot less queueName decls.
The text was updated successfully, but these errors were encountered: