Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/bmx280: New integration to generic BMX280 sensors tests #327

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

CW-75
Copy link
Collaborator

@CW-75 CW-75 commented Jul 26, 2022

Contribution description

This pr add supports to BMP280 sensors in the new driver_bmx280. Was modified the driver_bme280 folder to gives a generic name as driver_bmx280. Take careful with the I2c address used in both models, because bmp could be 0x77 too. In this case took the 0x76. Also when it's ran the test, the bmp280 has not support to read humidity in difference with the bme280, so in the test was added a pre-build conditional to knows what type of driver will be running.

Testing procedure

When you are running a BMP driver you need to specify before the build the test code

 make flash term DRIVER=bmp280_i2c

Note : if you don't specify the driver, by default will be loaded the bme_i2c

Issues/PRs references

Fixes #326

Copy link
Contributor

@luisan00 luisan00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👏

@CW-75 CW-75 merged commit 320cf06 into Mesh4all:main Jul 26, 2022
@CW-75 CW-75 deleted the feature/test_bmx280 branch July 26, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in the test/driver_bme280 not support the bmp280 model
2 participants