Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade of inputs and form editors #3318

Merged
merged 44 commits into from
Apr 19, 2024
Merged

Upgrade of inputs and form editors #3318

merged 44 commits into from
Apr 19, 2024

Conversation

tomasMizera
Copy link
Collaborator

@tomasMizera tomasMizera commented Apr 16, 2024

Todo:

Restructured inheritance of the form editors / inputs:
image

New mouse areas (green - checkbox; yellow - text; blue and red buttons):
Screenshot 2024-04-16 at 15 36 39

Copy link

github-actions bot commented Apr 16, 2024

Pull Request Test Coverage Report for Build 8754769287

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 110 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.03%) to 60.265%

Files with Coverage Reduction New Missed Lines %
input/app/position/providers/simulatedpositionprovider.cpp 1 90.91%
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginuserinfo.cpp 3 72.99%
input/app/mmstyle.h 47 1.98%
input/app/main.cpp 58 32.55%
Totals Coverage Status
Change from base Build 8722760827: -0.03%
Covered Lines: 7638
Relevant Lines: 12674

💛 - Coveralls

@tomasMizera
Copy link
Collaborator Author

Once merging, let's make sure to not squash! :)

tomasMizera and others added 12 commits April 18, 2024 15:24
* rework password input

* address review
* rework search

* use rightContentVisible and reorder declarations
…g-loop

Fix binding loop on implicitWidth in MMBaseSingleLineInput
* Rework photo editor

* Fix gallery editors page

* Address review
* fix setting the background for a MMSearchInput

* Doh, color
@tomasMizera tomasMizera changed the title WIP: Upgrade of inputs and form editors Upgrade of inputs and form editors Apr 19, 2024
@tomasMizera tomasMizera marked this pull request as ready for review April 19, 2024 14:50
Copy link
Contributor

@uclaros uclaros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment