-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade of inputs and form editors #3318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8754769287Details
💛 - Coveralls |
* Update MMFormNumberEditor * Fix suffix alignment
* MMSwitchInput, MMSwitchFormEditor * rework rightContentVisible * restore text part of MMSwitch * add leftContentVisible property and textClicked signal * fix clicking when readOnly
Once merging, let's make sure to not squash! :) |
Rework MMFormTextMultilineEditor
Rework MMFormSliderEditor
* rework password input * address review
* rework search * use rightContentVisible and reorder declarations
…g-loop Fix binding loop on implicitWidth in MMBaseSingleLineInput
Rework MMComboboxInput
* Rework photo editor * Fix gallery editors page * Address review
* fix setting the background for a MMSearchInput * Doh, color
* Rework MMFormRelationReferenceEditor * Address review comments
Rework MMFormScannerEditor
rework MMFormRichTextViewer
Rework MMFormGalleryEditor
don't open combobox if disabled
don't open calendar when disabled
Remove unused inputs code
Fix editor and input icon colours
tomasMizera
changed the title
WIP: Upgrade of inputs and form editors
Upgrade of inputs and form editors
Apr 19, 2024
uclaros
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\o/
This was
linked to
issues
Apr 19, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
Restructured inheritance of the form editors / inputs:
New mouse areas (green - checkbox; yellow - text; blue and red buttons):