Rework MMPasswordInput #3333
Merged
Rework MMPasswordInput #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasMizera
reviewed
Apr 18, 2024
app/qml/inputs/MMPasswordInput.qml
Outdated
| color: __style.transparentColor | ||
| } | ||
| } | ||
| textField.inputMethodHints: textField.inputMethodHints | Qt.ImhNoAutoUppercase |
There was a problem hiding this comment.
Won't this produce a binding loop? 🤔
There was a problem hiding this comment.
Hmm it does.. What's the proper way to do |= in qml?
Also why do we have inputMethodHints: Qt.ImhNoPredictiveText in the base class?
There was a problem hiding this comment.
We want to keep inputMethodHints: Qt.ImhNoPredictiveText for all inputs in the app for now. Predictive text was giving us a lot of issues.
I have not found a way to do |= in QML yet, but If you find a way, I will be excited! :)
app/qml/inputs/MMPasswordInput.qml
Outdated
| id: eyeButton | ||
|
|
||
| property bool pressed: false | ||
|
|
||
| anchors.verticalCenter: parent.verticalCenter | ||
|
|
||
| size: __style.icon24 | ||
| source: pressed ? __style.hideIcon : __style.showIcon | ||
| color: root.enabled ? __style.forestColor : __style.mediumGreenColor |
There was a problem hiding this comment.
Suggested change
| color: root.enabled ? __style.forestColor : __style.mediumGreenColor | |
| color: root.editState === "enabled" ? __style.forestColor : __style.mediumGreenColor |
tomasMizera
approved these changes
Apr 18, 2024
tomasMizera
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.