-
-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support types without object equal operator ( extend test for DateTime, TimeSpan ) #3152
Conversation
~ set CultureInfo on test start + add test for DateTime + add test for TimeSpan
+ implement value type handling for expression compare ~ fix timespan test to use correct expecting values
So basically this is to access value types within structs? Is that it? @stsrki are we doing net6 only on 1.0.0? Maybe we can think about adding the new Date Types in .NET6 to the tests also. @puschie286 why |
+ add more corner test ~ replace activator with expression default ~ replace member.reflectedtype with item.type
@David-Moreira its for comparing struct that doesnt have a equal operator which accept objects. you are right with Expression.Default, thanks for pointing that out :) replaced the reflection approach with your suggested expression approach |
Way simpler change, makes more sense. If all tests are passing, LGTM. @stsrki wanna consider this for 0.9.5? Seems worthy honestly. |
@David-Moreira Yeah, it is not breaking any API so it can be done as part of 095. LGTM |
* Extract hex digits cache regex (#3140) * Start With Benchmark * Add ThemeGenerator for baseline benchmark * ExtractHexDigits cache REGEX * Methods Benchmarked + Tests * Theme Generator : Refactor ExtractHexDigits * Add test making sure ThemeGenerator is still logically equivalent to previous version. * Run format * Rename IsHexDigit Co-authored-by: Mladen Macanovic <[email protected]> * Fix Table THead Query Selector to target only first THead for FixedHeader and Resize features. (#3155) * Support types without object equal operator ( extend test for DateTime, TimeSpan ) (#3152) * Add test for DateTime and TimeSpan ~ set CultureInfo on test start + add test for DateTime + add test for TimeSpan * Value type comparison + implement value type handling for expression compare ~ fix timespan test to use correct expecting values * add more test & simplify + add more corner test ~ replace activator with expression default ~ replace member.reflectedtype with item.type * Fix typos in docs (#3164) * Mark snackbarInfos as readonly * Fix unused snackbar title parameter * Override ReleaseResources * Fix missing comment param Co-authored-by: David <[email protected]> Co-authored-by: puschie286 <[email protected]>
* Unused vars (#3165) * Extract hex digits cache regex (#3140) * Start With Benchmark * Add ThemeGenerator for baseline benchmark * ExtractHexDigits cache REGEX * Methods Benchmarked + Tests * Theme Generator : Refactor ExtractHexDigits * Add test making sure ThemeGenerator is still logically equivalent to previous version. * Run format * Rename IsHexDigit Co-authored-by: Mladen Macanovic <[email protected]> * Fix Table THead Query Selector to target only first THead for FixedHeader and Resize features. (#3155) * Support types without object equal operator ( extend test for DateTime, TimeSpan ) (#3152) * Add test for DateTime and TimeSpan ~ set CultureInfo on test start + add test for DateTime + add test for TimeSpan * Value type comparison + implement value type handling for expression compare ~ fix timespan test to use correct expecting values * add more test & simplify + add more corner test ~ replace activator with expression default ~ replace member.reflectedtype with item.type * Fix typos in docs (#3164) * Mark snackbarInfos as readonly * Fix unused snackbar title parameter * Override ReleaseResources * Fix missing comment param Co-authored-by: David <[email protected]> Co-authored-by: puschie286 <[email protected]> * Revert "Unused vars (#3165)" (#3167) This reverts commit 13c9004. * added czech translations for components Added czech tranlations for data grid , file edit , time picker and date picker components * Added translations for carousel and color picker Added czech translations for carousel and color picker Co-authored-by: Mladen Macanović <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: puschie286 <[email protected]>
Implement compare for value types.
Add test for DateTime and TimeSpan