Extract hex digits cache regex #3140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…previous version.
stsrki
approved these changes
Nov 20, 2021
|
I felt like it was faster too haha but I didn't bother to go compare both versions side by side haha. I think every internal string manipulation can use it. You have some substringing in the theme generator for example. It should be a bit faster and without allocations, we'll do it once we clear up out the big stuff in the release. |
stsrki
added a commit
that referenced
this pull request
Nov 25, 2021
* Extract hex digits cache regex (#3140) * Start With Benchmark * Add ThemeGenerator for baseline benchmark * ExtractHexDigits cache REGEX * Methods Benchmarked + Tests * Theme Generator : Refactor ExtractHexDigits * Add test making sure ThemeGenerator is still logically equivalent to previous version. * Run format * Rename IsHexDigit Co-authored-by: Mladen Macanovic <[email protected]> * Fix Table THead Query Selector to target only first THead for FixedHeader and Resize features. (#3155) * Support types without object equal operator ( extend test for DateTime, TimeSpan ) (#3152) * Add test for DateTime and TimeSpan ~ set CultureInfo on test start + add test for DateTime + add test for TimeSpan * Value type comparison + implement value type handling for expression compare ~ fix timespan test to use correct expecting values * add more test & simplify + add more corner test ~ replace activator with expression default ~ replace member.reflectedtype with item.type * Fix typos in docs (#3164) * Mark snackbarInfos as readonly * Fix unused snackbar title parameter * Override ReleaseResources * Fix missing comment param Co-authored-by: David <[email protected]> Co-authored-by: puschie286 <[email protected]>
stsrki
added a commit
that referenced
this pull request
Dec 8, 2021
* Unused vars (#3165) * Extract hex digits cache regex (#3140) * Start With Benchmark * Add ThemeGenerator for baseline benchmark * ExtractHexDigits cache REGEX * Methods Benchmarked + Tests * Theme Generator : Refactor ExtractHexDigits * Add test making sure ThemeGenerator is still logically equivalent to previous version. * Run format * Rename IsHexDigit Co-authored-by: Mladen Macanovic <[email protected]> * Fix Table THead Query Selector to target only first THead for FixedHeader and Resize features. (#3155) * Support types without object equal operator ( extend test for DateTime, TimeSpan ) (#3152) * Add test for DateTime and TimeSpan ~ set CultureInfo on test start + add test for DateTime + add test for TimeSpan * Value type comparison + implement value type handling for expression compare ~ fix timespan test to use correct expecting values * add more test & simplify + add more corner test ~ replace activator with expression default ~ replace member.reflectedtype with item.type * Fix typos in docs (#3164) * Mark snackbarInfos as readonly * Fix unused snackbar title parameter * Override ReleaseResources * Fix missing comment param Co-authored-by: David <[email protected]> Co-authored-by: puschie286 <[email protected]> * Revert "Unused vars (#3165)" (#3167) This reverts commit 13c9004. * added czech translations for components Added czech tranlations for data grid , file edit , time picker and date picker components * Added translations for carousel and color picker Added czech translations for carousel and color picker Co-authored-by: Mladen Macanović <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: puschie286 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3133
Didn't have time to finish yet.
Need to test Regex.Matches vs our version as I am not 100% it's 100% logically equivalent. If it is, then it's way faster.
Also need to do some reading up on https://docs.microsoft.com/en-us/dotnet/standard/base-types/best-practices as static method
Regex.IsMatchmight also be worth considering...Edit: I'm not sure if additional steps need to be taken to actually take advantage of
RegexOptions.Compiled?Also consider using Span in the future to do internal optimizations in string manipulation... might be worth it for 1.0.0
A good resource:
https://www.youtube.com/watch?v=FM5dpxJMULY&ab_channel=NickChapsas