Layout Improvements #1090
Merged
Layout Improvements #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsrki
reviewed
Jul 6, 2020
Source/Blazorise/Layout.razor
Outdated
| @@ -3,6 +3,10 @@ | |||
| { | |||
| <section @ref="@ElementRef" id="@ElementId" class="@ClassNames" style="@StyleNames" @attributes="@Attributes"> | |||
| <CascadingValue Value=this> | |||
| @if ( Loading ) | |||
| { | |||
| <div class="@LoadingClass"></div> | |||
There was a problem hiding this comment.
I was thinking of adding additional [Parameter] public RenderFragment LoadingTemplate { get; set; }, and then add it like:
@if ( LoadingTemplate != null )
{
@LoadingTemplate
}
else
{
<div class="@LoadingClass"></div>
}There was a problem hiding this comment.
Ahh I see, looks good!
Source/Blazorise/Layout.razor.cs
Outdated
| private bool bodyClassApplied; | ||
| private bool loading; | ||
|
|
||
| private string loadingClass = "b-layout-loading-spinner"; |
There was a problem hiding this comment.
Will do, was just doing this quickly to get feedback on templating idea :)
| } | ||
|
|
||
| [Parameter] | ||
| public string LoadingClass |
There was a problem hiding this comment.
Make LoadingClass as custom class to be added into loading ClassBuilder
docs/_docs/components/bar.md
Outdated
| @@ -59,8 +59,8 @@ The bar component has the following structure: | |||
| </BarStart> | |||
| <BarEnd> | |||
| <BarItem> | |||
| <Button Color="Color.Primary">Sign up</Button> | |||
| <Button Color="Color.Secondary">Log in</Button> | |||
| <button Color="Color.Primary">Sign up</button> | |||
There was a problem hiding this comment.
Why button instead of Button? Is this a mistake?
There was a problem hiding this comment.
Oops! Yes this is a mistake.
Must've auto save formatting
|
Test and working like a charm. Excellent work! |
This was referenced Jul 6, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details can be found at #1089
@stsrki I have added a
LoadingClasstoLayoutto represent what you suggested on #1084.This can be overridden with CSS for a spinner or progress bar, but I have also provided a default.
Let me know what you think, didn't want to spend too much time on that right now.