Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LayoutHeader moving #1283

Closed
gallwood opened this issue Aug 28, 2020 · 6 comments
Closed

LayoutHeader moving #1283

gallwood opened this issue Aug 28, 2020 · 6 comments
Assignees
Labels
Type: Bug 🐞 Something isn't working
Milestone

Comments

@gallwood
Copy link

Describe the bug
I have a MainLayout file that contains a Layout component with a LayoutHeader and LayoutContent. Inside the header is a Bar comp.

In my page body, if I have a simple table with more that 35 rows in it, once I scroll down to the bottom of the page, the Bar in the header scrolls out of view.

Expected behavior
I would expect the Header bar to remain static.

Example repo:
https://github.com/gallwood/Scrolling

@MitchellNZ
Copy link
Contributor

Thanks for taking the time to make an example repo!

I haven't had chance to test this myself yet with your example...
But I have a feeling this might be fixed with changes in #1090 🤔

I will give it a try tomorrow, but if you get round to it before me, I'd recommend trying out the latest preview version of Blazoirse with this to see if its already fixed in 0.9.2.

@gallwood
Copy link
Author

gallwood commented Sep 2, 2020

Hey.

I've just tried the pre-release 0.9.2 version. Sadly it had no effect. Mind you, I didn't change any source code, just recompiled with the later packages.

@stsrki
Copy link
Collaborator

stsrki commented Sep 2, 2020

@gallwood On which branch you tried? The changes that @MitchellNZ was talking about are still in PR, and needs to be merged.

@gallwood
Copy link
Author

gallwood commented Sep 2, 2020

@stsrki good point. I simply used the 0.9.2 release from your private package store as referenced above. If I get time tomorrow or Friday, I can try the branch the PR is coming from. (In theory :) )

@stsrki
Copy link
Collaborator

stsrki commented Sep 2, 2020

No worries, I will release it soon as preview anyways. There just needs to be some smaller things done by @MitchellNZ

@MitchellNZ
Copy link
Contributor

@stsrki @gallwood
I just tested this, and I don't think any of the changes I have done will fix this, unfortunately.

Looks like it could be a new bug related to not having a sidebar.
I will need to investigate further, as this is not typically a scenario I test with.

Thanks for reporting!

@MitchellNZ MitchellNZ added the Status: Investigate Needs to investigate more to what can be done. label Sep 2, 2020
@MitchellNZ MitchellNZ self-assigned this Sep 2, 2020
@MitchellNZ MitchellNZ added the Type: Possible Bug Needs to investigate more to see if it's an actual bug. label Sep 2, 2020
@stsrki stsrki assigned David-Moreira and unassigned MitchellNZ Jun 30, 2021
@stsrki stsrki added this to the 0.9.3 milestone Jun 30, 2021
@stsrki stsrki assigned stsrki and unassigned David-Moreira Jun 30, 2021
@stsrki stsrki modified the milestones: 0.9.3, 0.9.4 Jun 30, 2021
@stsrki stsrki added Type: Bug 🐞 Something isn't working and removed Status: Investigate Needs to investigate more to what can be done. Type: Possible Bug Needs to investigate more to see if it's an actual bug. labels Jun 30, 2021
This was referenced Jun 30, 2021
@stsrki stsrki closed this as completed Jun 30, 2021
@stsrki stsrki moved this to ✔ Done in Development Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐞 Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants