Fixed Random-Camouflage Path Handling for Alternate Directory Format #4896
Conversation
Accounted for backslash escape sequences in camouflage file paths to ensure compatibility across different operating systems. Added an alternate root directory constant and updated the path sanitization to replace the alternate format correctly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4896 +/- ##
============================================
- Coverage 10.46% 10.45% -0.02%
+ Complexity 6017 6009 -8
============================================
Files 952 952
Lines 132755 132758 +3
Branches 19308 19308
============================================
- Hits 13894 13880 -14
- Misses 117516 117528 +12
- Partials 1345 1350 +5 ☔ View full report in Codecov by Sentry. |
|
This should not be merged until someone on a windows system confirms it is working as intended. Action This can be tested by starting a new campaign, picking a contract from the market (any contract), and then editing that contract. If camo has been randomly generated then this fix works. If it's showing a red 'X' we need to explore other options. |
Corrected the typo in the file path from "mages" to "images". This ensures the application correctly locates the camouflage directory when sanitizing the file path.
|
Tested the artifact this AM 
Some oddites in the logs |
|
Can you DM me a save, I want to verify the issue is the same and not something else that just happens to give the same results |
Refactored path sanitization by removing the alternative root directory string. Simplified the file path replacement logic to handle any path separators in a unified manner. This reduces code complexity and potential errors.
Replaced backslashes with forward slashes when determining file categories. This ensured consistency and fixed potential issues on non-Windows platforms.
|
QA have confirmed this is working now, so it should be good to merge whenever |
Accounted for backslash escape sequences in camouflage file paths to ensure compatibility across different operating systems. Added an alternate root directory constant and updated the path sanitization to replace the alternate format correctly.
Closes #4895