Corrected Experience Rating Calculation in Reputation #4804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified the calculation of regular entity experience by removing redundant skill handling logic and using more consistent variable names. Ensured that personnel count increments only if the total experience is greater than zero (to exclude support personnel). Corrected experience rating calculation to use derived target numbers and not skill levels.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4804 +/- ##
============================================
+ Coverage 10.61% 10.76% +0.14%
- Complexity 5655 5664 +9
============================================
Files 948 948
Lines 132553 132549 -4
Branches 19048 19044 -4
============================================
+ Hits 14072 14264 +192
+ Misses 117246 117048 -198
- Partials 1235 1237 +2 ☔ View full report in Codecov by Sentry. |
# Conflicts: # MekHQ/src/mekhq/campaign/rating/CamOpsReputation/AverageExperienceRating.java
|
Updated to account for the recent name change project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the calculation of regular entity experience by removing redundant skill handling logic and using more consistent variable names. Ensured that personnel count increments only if the total experience is greater than zero (to exclude support personnel). Corrected experience rating calculation to use derived target numbers and not skill levels.
Closes #4803 & #4802