Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

50.00 - Unit Veterancy Skill Level seems incorrect. #4802

Closed
Thom293 opened this issue Sep 7, 2024 · 6 comments
Closed

50.00 - Unit Veterancy Skill Level seems incorrect. #4802

Thom293 opened this issue Sep 7, 2024 · 6 comments

Comments

@Thom293
Copy link
Contributor

Thom293 commented Sep 7, 2024

Generate brand new company, seems to always be rated as Veteran. It was explained that it should calculate average level across combat only personnel.

To repeat - generate company, advanced a week so unit report would change, look at roster and compare.

My personal Preset - Zero Vets:
image
Campaign Ops Preset - 3 Vets
image
Complete Experience Preset - 1 Elite, 1 Vet, 2 Green, 3 Ultra Green.
image

@ObviousTech
Copy link
Contributor

ObviousTech commented Sep 7, 2024

seeing this as well. combat personnel skills levels are 2 veteran, 6 regular, 5 green (or if counting only TOE units it's 2 vet, 4 reg, 4 green)

techs: 5 vet, 4 reg, 2 green, 1 ultra-green.

even after removing the 5 veteran techs (and advancing a week), the experience level is still calculating as Veteran.

If I switch the campaign options to FM-Mercs reputation, the experience changes to Regular. So it may be something specific to Campaign Ops reputation

@Tzahr
Copy link

Tzahr commented Sep 7, 2024

MHQ Code Revision: 1348549

My combat personnel is composed of:
56 Regulars, 62 Veterans, 52 Elites (manually counted, could be a few off give or take).
Not counting Techs, the vast majority of which are Veterans.

image

I'll append my full savegame and customs, in case a dataset is needed.

1st Rimward Hussars.zip
customs.zip

@IllianiCBT
Copy link
Collaborator

So my first inclination is that one of a couple things could be happening:

  • we only calculate personnel assigned to units (this is RAW) which could skew player expected values
  • As the reputation calculation is based on actual skill levels, not experience level, it might not match up with listed experience level. This is RAW.
  • similar to the above, if the non-standard skill averaging is being used that might throw off player expected values, as it doesn’t apply to reputation
  • The calculation could be returning an incorrect value - it shouldn’t be, as it was tested thoroughly but it’s always a possibility.

Unless investigation shows the final option is true this is working as intended.

@IllianiCBT
Copy link
Collaborator

Closing this report as upon investigation the system was found to be working as intended. This can be confirmed by manually totally all relevant skill levels (the ones visible in the Edit Person screen) and then comparing that value to the value shown in debug logging.

@Thom293
Copy link
Contributor Author

Thom293 commented Sep 7, 2024

Please re-open as this bug report is accurate.

@IllianiCBT
Copy link
Collaborator

Closing as resolved (after further discussion there was found to be an issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants