Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Text for Against the Bot Campaign Option #4567

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Clarified that StratCon requires Against the Bot rules in the checkbox text. This makes it explicit that users need both sets of rules for StratCon.

Closes #4550

Clarified that StratCon requires Against the Bot rules in the checkbox text. This makes it explicit that users need both sets of rules for StratCon.
@IllianiCBT IllianiCBT added the GUI label Aug 7, 2024
@IllianiCBT IllianiCBT self-assigned this Aug 7, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.32%. Comparing base (b5ff179) to head (6a5214b).
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4567      +/-   ##
============================================
- Coverage     10.32%   10.32%   -0.01%     
  Complexity     5816     5816              
============================================
  Files           935      935              
  Lines        128792   128802      +10     
  Branches      18951    18951              
============================================
  Hits          13296    13296              
- Misses       114220   114230      +10     
  Partials       1276     1276              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we already do this, but could you make it that when you click Stratcon, it activates the AtB option.

@IllianiCBT
Copy link
Collaborator Author

It's not possible to enable StratCon without enabling AtB first, as deselecting AtB disables the entire tab.

@IllianiCBT IllianiCBT merged commit 140a931 into MegaMek:master Aug 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

50.00 "Use StratCon Rules" appears twice on that Campaign Options tab.
3 participants