Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

50.00 "Use StratCon Rules" appears twice on that Campaign Options tab. #4550

Closed
Thom293 opened this issue Aug 5, 2024 · 12 comments · Fixed by #4567
Closed

50.00 "Use StratCon Rules" appears twice on that Campaign Options tab. #4550

Thom293 opened this issue Aug 5, 2024 · 12 comments · Fixed by #4567
Labels

Comments

@Thom293
Copy link
Contributor

Thom293 commented Aug 5, 2024

Also the top one seems confusingly named.

image

@IllianiCBT IllianiCBT self-assigned this Aug 5, 2024
@IllianiCBT
Copy link
Collaborator

That looks like an error caused by a bad merge.

@Thom293
Copy link
Contributor Author

Thom293 commented Aug 5, 2024

Its the OID version updated today, if it matters.

@IllianiCBT
Copy link
Collaborator

Wait, this is actually working as intended. It looks like the verbiage was changed to show that this option also relates to StratCon

@Thom293
Copy link
Contributor Author

Thom293 commented Aug 5, 2024

Then if you scroll to the bottom - that one should be deleted I think? Sorry it was too big to get both on one screen.

@IllianiCBT
Copy link
Collaborator

I think the top option might need to be reworded. They’re both needed, because the top one enables AtB, while the bottom enables StratCon. I can’t remember which contributor changed the wording, but it was part of a greater attempt to help clear things up. I do agree that here it’s probably not as clear as they hoped.

@Thom293
Copy link
Contributor Author

Thom293 commented Aug 5, 2024

Yeah in the past always needed both for SC.

I always thought it was odd that SC one was at the bottom off the bottom of the page. Now that its been promoted to beta, perhaps both should be at top? Regardless, top one is kinda confusing.

@IllianiCBT
Copy link
Collaborator

The AtB tab is full of legacy formatting so it’s a bit of a pain to change

@Thom293
Copy link
Contributor Author

Thom293 commented Aug 5, 2024

Maybe something like "Enable AtB (AtB must also be enabled for StratCon)"
And the 2nd: "Enable StratCon (AtB must also be enabled for StratCon)"

@repligator
Copy link
Collaborator

I can’t remember which contributor changed the wording, but it was part of a greater attempt to help clear things up. I do agree that here it’s probably not as clear as they hoped.

Ha, that'd be me. See #4396 . I agree that the wording leaves a lot to be desired.

@repligator repligator added the GUI label Aug 5, 2024
@IllianiCBT IllianiCBT removed their assignment Aug 7, 2024
@IllianiCBT
Copy link
Collaborator

Ha, that'd be me. See #4396 . I agree that the wording leaves a lot to be desired.

Do you want to handle the fix, or should I see if I can conjure some fancy words?

@repligator
Copy link
Collaborator

Ha, that'd be me. See #4396 . I agree that the wording leaves a lot to be desired.

Do you want to handle the fix, or should I see if I can conjure some fancy words?

If it's all-right I'll leave the wording to you.

@IllianiCBT
Copy link
Collaborator

Closing as resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants