Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Tooltips for the Marriageable & Trying to Conceive Flags #4082

Merged

Conversation

IllianiCBT
Copy link
Collaborator

@IllianiCBT IllianiCBT commented May 15, 2024

This PR modifies the 'Marriageable' and 'Trying to Conceive' flags to explicitly state that underage personnel will not be considered eligible for marriage or reproduction, even if these flags are enabled.

I also changed these tooltips to be multiline tooltips, as they're a little wordy.

closes #4080

Updated the tooltip functionality in the PersonnelTableMouseAdapter class to make use of MultiLineTooltip. The tooltips for "Marriageable" and "Trying to Conceive" options have been updated.
@IllianiCBT IllianiCBT self-assigned this May 15, 2024
@IllianiCBT IllianiCBT added Personnel Personnel-related Issues GUI labels May 15, 2024
Copy link
Member

@SJuliez SJuliez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest changing that call. Otherwise allgood.

The tooltip text for the "Marriageable" menu item has been updated to use the String.format method for cleaner text replacement. Additionally, the GUI properties file has been adjusted to support this update, changing the replacement syntax to use a placeholder ("%s") for the minimum marriage age.
@HammerGS HammerGS merged commit 7071247 into MegaMek:master May 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Personnel Personnel-related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: Remove Child Marriage and Knocked Up Children Flags
3 participants