Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Remove Child Marriage and Knocked Up Children Flags #4080

Closed
johnboyjjb opened this issue May 14, 2024 · 4 comments · Fixed by #4082
Closed

RFE: Remove Child Marriage and Knocked Up Children Flags #4080

johnboyjjb opened this issue May 14, 2024 · 4 comments · Fixed by #4082
Assignees
Labels
Personnel Personnel-related Issues

Comments

@johnboyjjb
Copy link

Not sure it works this way, as I've not seen any pregnant and married 4 year olds, but it looks like they can be flagged for marriage and pregnancy by default.
Screenshot 2024-05-14 122538
I have not changed any settings on this person. There may be other calculations which prevent the marriage calculation and the pregnancy calculation from picking these up. It does look like I cannot force them to be pregnant until they turn 14, which I guess is good.
Maybe mask the flag until target age or just don't care since it appears to be only a flag problem.

@IllianiCBT
Copy link
Collaborator

I already have a PR open to address child pregnancy. I'll take a look into this later tonight (writing documentation atm).

@IllianiCBT IllianiCBT added the Personnel Personnel-related Issues label May 14, 2024
@IllianiCBT IllianiCBT self-assigned this May 14, 2024
@johnboyjjb
Copy link
Author

Apologies. I guess my searching abilities on github suck. Though I guess I did focus on the marriage part first.

@IllianiCBT
Copy link
Collaborator

Apologies. I guess my searching abilities on github suck. Though I guess I did focus on the marriage part first.

No apology necessary, your suggestion here isn't a part of my PR, so it's a good addition

@IllianiCBT
Copy link
Collaborator

After thorough internal deliberation on this matter, we acknowledge your perspective, but presently, we've decided against concealing these flags.

While these flags remain inactive during a person's underage period, concealing them poses a challenge: users cannot deactivate the flag until after the individual reaches the appropriate age. Something that would be difficult for users to track.

Our solution involves revising the tooltips associated with these flags, explicitly indicating the age at which personnel become eligible for marriage or reproduction.

@IllianiCBT IllianiCBT added Won't Fix Invalid/Won't be fixed and removed Won't Fix Invalid/Won't be fixed labels May 15, 2024
HammerGS added a commit that referenced this issue May 16, 2024
+ PR #4041: Updated isChild()
+ Fix #4080: Updated Tooltips for the Marriageable & Trying to Conceive Flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Personnel Personnel-related Issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants